It should probably be packed, but at this point I can't apply this patch
without verifying this doesn't negatively effect other platforms or
compatability with older versions.
Regards
-steve
On Tue, 2008-03-11 at 20:47 +0900, Masatake YAMATO wrote:
> Hi,
>
> In totempg.c, a pointer pointing struct totempg_mcast data buffer is
> passed to lower layers. At the end the pointer is passed to sendmsg.
> So I think totempg_mcast must be packed like struct message_header in
> totemsrp.c. If what I wrote here is true, please apply following
> patch.
> If not, could you tell me the reason? I'd like to understand openais
> more deeply.
>
> Masatake YAMATO
>
> diff
> -ruN /srv/sources/src-upstream/lcopy-SOURCES/openais-trunk/exec/totempg.c
> /tmp/openais-trunk/exec/totempg.c
> --- /srv/sources/src-upstream/lcopy-SOURCES/openais-trunk/exec/totempg.c
> 2007-09-09 22:49:32.000000000 +0900
> +++ /tmp/openais-trunk/exec/totempg.c 2008-03-11 20:37:03.000000000
> +0900
> @@ -108,7 +108,7 @@
> struct totempg_mcast_header {
> short version;
> short type;
> -};
> +} __attribute__((packed));
>
>
> /*
> @@ -133,7 +133,7 @@
> /*
> * data for messages
> */
> -};
> +} __attribute__((packed));
_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais
