The patch looks pretty good except the use of logsys in the objdb. Any errors should be returned via the write interface function call, and not logged via the logging system. If the user wants to log the errors, they may do so.
The reason for this constraint is so that the object database may be linked into an application with the confdb library as well to provide configuration when Corosync isn't running. Regards -steve On Wed, 2008-04-23 at 13:29 +0100, Christine Caulfield wrote: > This patch adds a config_writeconfig() call to the configuration API, > this is called by objdb when object_write_config() is called. > > > Chrissie > _______________________________________________ > Openais mailing list > [email protected] > https://lists.linux-foundation.org/mailman/listinfo/openais _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
