Hi Steven,

the patch removes a lot of duplicate work that is already available in logsys via logsys_facility_id_get that does the same (and better) conversion.

Please apply.

Fabio

--
I'm going to make him an offer he can't refuse.
Index: exec/mainconfig.c
===================================================================
--- exec/mainconfig.c   (revision 1552)
+++ exec/mainconfig.c   (working copy)
@@ -179,33 +179,8 @@
                }
 
                if (!objdb_get_string (objdb,object_service_handle, 
"syslog_facility", &value)) {
-                       if (strcmp (value, "daemon") == 0) {
-                               main_config->syslog_facility = LOG_DAEMON;
-                       } else
-                       if (strcmp (value, "local0") == 0) {
-                               main_config->syslog_facility = LOG_LOCAL0;
-                       } else
-                       if (strcmp (value, "local1") == 0) {
-                               main_config->syslog_facility = LOG_LOCAL1;
-                       } else
-                       if (strcmp (value, "local2") == 0) {
-                               main_config->syslog_facility = LOG_LOCAL2;
-                       } else
-                       if (strcmp (value, "local3") == 0) {
-                               main_config->syslog_facility = LOG_LOCAL3;
-                       } else
-                       if (strcmp (value, "local4") == 0) {
-                               main_config->syslog_facility = LOG_LOCAL4;
-                       } else
-                       if (strcmp (value, "local5") == 0) {
-                               main_config->syslog_facility = LOG_LOCAL5;
-                       } else
-                       if (strcmp (value, "local6") == 0) {
-                               main_config->syslog_facility = LOG_LOCAL6;
-                       } else
-                       if (strcmp (value, "local7") == 0) {
-                               main_config->syslog_facility = LOG_LOCAL7;
-                       } else {
+                       main_config->syslog_facility = 
logsys_facility_id_get(value);
+                       if (main_config->syslog_facility < 0) {
                                error_reason = "unknown syslog facility 
specified";
                                goto parse_error;
                        }
_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais

Reply via email to