Hi guys,
there is a substantial problem in the way keys and objectes are created
within the objdb.
Let's assume this config file:
<foo>
<bar name="1" action="off"/>
<bar name="2" action="on"/>
</foo>
(very similar to our fence method configuration snippet)
Using list_add to create the keys and objects, the configuration in the
object db is mirrored:
<foo>
<bar action="on" name="2"/>
<bar action="off" name="1"/>
</foo>
the patch in attachment change list_add into list_add_tail to insert data
in the objdb in the same order as they have been pushed.
While _generally_ this shouldn't be an issue, we have services like fence,
that relies on the correct order of data to be returned from the objdb in
order to perform their operations correctly.
Please apply
Fabio
--
I'm going to make him an offer he can't refuse.
Index: exec/objdb.c
===================================================================
--- exec/objdb.c (revision 1626)
+++ exec/objdb.c (working copy)
@@ -360,7 +360,7 @@
object_instance->object_name_len = object_name_len;
- list_add (&object_instance->child_list, &parent_instance->child_head);
+ list_add_tail (&object_instance->child_list,
&parent_instance->child_head);
object_instance->object_handle = *object_handle;
object_instance->find_child_list = &object_instance->child_head;
@@ -488,7 +488,7 @@
object_key->value_len = value_len;
list_init (&object_key->list);
- list_add (&object_key->list, &instance->key_head);
+ list_add_tail (&object_key->list, &instance->key_head);
object_key_changed_notification(object_handle, key_name, key_len,
value,
value_len, OBJECT_KEY_CREATED);
_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais
