On Aug 21, 2008, at 8:19 PM, Steven Dake wrote: > On Thu, 2008-08-21 at 09:48 +0200, Andrew Beekhof wrote: >> >> >> Why would there even be an autogenerated id if the admin had supplied >> one? >> If the admin asks for an id that overflows a signed integer, then >> thats >> what they get. >> >> I don't think anyone's suggesting we fold _all_ nodeids back into >> the 0..2^31 range, only that the autogenerated ones should be in this >> range. >> > > The patch you proposed breaks compatibility on the wire to achieve > this > result.
How? How is it any different having netif_determine() assign a nodeid of 1234 (compared to -1234) vs. the admin manually specifying 1234 in openais.conf? > Further it does this in the totem layer which other third party > libraries can use. Thats kinda the point. > > > There is no way to fold autogenerated node ids into a 31 bit address > space without breaking wire compatibility if it is done in the totem > code itself which is who generates the node ids. > > > >>> over the wire to transmit it up the stack to >>> the plugin's various node id functions such as confchg et al. That >>> would break protocol compatibility. >>> >>> Regards >>> -steve >>>> >>> >> > _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
