On Fri, 2009-01-23 at 14:05 +0000, Chrissie Caulfield wrote: > Fabio M. Di Nitto wrote: > > Hi, > > > This isn't a NACK but there are a couple of comments I have. > > Firstly, the endpwent and endgrent calls are redundant (according to my > interpretation of the man pages) as they are only needed with the > getpwend and getgrent calls. Yes, I know they are in the original code > and they *might* be there for a very good reason, but I thought I'd > mention it.
Yes I read the same man page too and I did prefer to take the safe route here and re-use the same code from Steven. > > Secondly, I think the entries in mainconfig should be renamed uid & gid > rather than left as user & group, to avoid confusion. Ok. I am absolutely fine to do that. Would this change fulfill your requirements for ACK? Thanks Fabio _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
