Hi Steven,

found some more things to handle in release:

configure.ac:

configure.ac:AC_INIT([corosync], [0.95], [[email protected]])

the second entry needs to match the release version.

Here is my suggestion:

Index: trunk/configure.ac
===================================================================
--- trunk/configure.ac  (revision 1890)
+++ trunk/configure.ac  (working copy)
@@ -4,7 +4,7 @@
 # bootstrap / init
 AC_PREREQ([2.61])
 
-AC_INIT([corosync], [0.95], [[email protected]])
+AC_INIT([corosync], [trunk], [[email protected]])
 AM_INIT_AUTOMAKE
 
 AC_CONFIG_SRCDIR([lib/coroipcc.c])

so we keep trunk always on [trunk] version.

In the release script add this line:

sed -i -e 's#\[trunk\]#\['$(VERSION)'\]#' \
        tags/corosync-$(VERSION)/configure.ac

that will set the right version in configure.ac.

The sed line is "simple". It means that trunk will sort of become a
reserved keyword in configure.ac.

Fabio

PS I didn't commit this to avoid clashing with your patch.

On Sun, 2009-03-22 at 11:21 -0700, Steven Dake wrote:
> sounds good
> 
> On Sun, 2009-03-22 at 18:48 +0100, Fabio M. Di Nitto wrote:
> > On Sun, 2009-03-22 at 09:44 -0700, Steven Dake wrote:
> > > This patch adds the proper logic to tag a release and build the release
> > > tarball with the new automake system in mind.
> > > 
> > > The process ensures the following:
> > > * autogen and configures the tree
> > > * does a make dist and make distcheck to make sure the tree will rebuild
> > > * adds only the files added by autogen.sh that are necessary for a
> > > proper build to the tagged directory.  This list is taken from the
> > > tarball created by the make dist step.
> > > * creates a tarball from the tagged directory
> > > 
> > > I manually did a make distcheck on this tarball and it appears to work.
> > 
> > Things to do after the tarball release is generated in the script:
> > 
> > cd trunk; make maintainer-clean
> > 
> > > to try for yourself, execute
> > > 
> > > make trunk VERSION=0.95
> > 
> > this would probably generate random tags and commits.. not sure you want
> > people to do that :)
> > 
> > We still need to do a manual check for this first release (i'd suggest
> > we do it for a few just to get used to the procedure) but basically we
> > want to compare 0.94 files with 0.95 and make sure all expected files
> > are there. Specially the way in which make dist/distcheck work implies
> > certain info in the Makefile.am that we might have missed by mistake and
> > distcheck doesn't catch (for example I was missing index.html from man/
> > but nothing was failing because of the way the Makefile was written).
> > 
> > I'll happily help you to do this tomorrow..
> > 
> > Fabio
> > 
> > 

_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais

Reply via email to