merged. Thanks! -steve
On Thu, 2009-04-02 at 14:29 +0200, Jan Friesse wrote: > Jim, > thanks for pointing bugs. Attached patch should be fine (I hope). > > Regards, > Honza > > Jim Meyering wrote: > > Jan Friesse wrote: > >> Attached patch solves possible problems of overflow buffer, which can > >> happened with sprintf. I tried to change only files where it makes sense > >> (so basically, where in format is something like %s) and I hope I catch > >> all cases. > >> > >> > >> Index: test/sa_error.c > > ... > >> - sprintf (test_result, > >> + sprintf (test_result, sizeof(test_result), > > ... > >> Index: lcr/lcr_ifact.c > > ... > >> - sprintf (filename_cat, "%s/%s", path, filename); > >> + sprintf (filename_cat, sizeof(filename_cat), "%s/%s", path, filename); > > > > Oops. you meant to convert to snprintf. > > _______________________________________________ > Openais mailing list > [email protected] > https://lists.linux-foundation.org/mailman/listinfo/openais _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
