good for merge Jim, for the external APIs that you change with size_t parameters, could you keep a list of those apis so that the list can be published after your done? (Like this patch changes a parameter in cfg)
Regards -steve On Fri, 2009-04-03 at 21:28 +0200, Jim Meyering wrote: > From: Jim Meyering <[email protected]> > > * lib/cfg.c (corosync_cfg_get_node_addrs): Make "max_addrs" size_t. > (corosync_cfg_kill_node): Make "reason" const. > * include/corosync/cfg.h: Update prototypes. > --- > include/corosync/cfg.h | 4 ++-- > lib/cfg.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/corosync/cfg.h b/include/corosync/cfg.h > index 7c201bb..127fedf 100644 > --- a/include/corosync/cfg.h > +++ b/include/corosync/cfg.h > @@ -203,7 +203,7 @@ cs_error_t > corosync_cfg_kill_node ( > corosync_cfg_handle_t cfg_handle, > unsigned int nodeid, > - char *reason); > + const char *reason); > > cs_error_t > corosync_cfg_try_shutdown ( > @@ -231,7 +231,7 @@ cs_error_t > corosync_cfg_get_node_addrs ( > corosync_cfg_handle_t cfg_handle, > int nodeid, > - int max_addrs, > + size_t max_addrs, > int *num_addrs, > corosync_cfg_node_address_t *addrs); > > diff --git a/lib/cfg.c b/lib/cfg.c > index 8ff2368..c61f63b 100644 > --- a/lib/cfg.c > +++ b/lib/cfg.c > @@ -678,7 +678,7 @@ cs_error_t > corosync_cfg_kill_node ( > corosync_cfg_handle_t cfg_handle, > unsigned int nodeid, > - char *reason) > + const char *reason) > { > struct cfg_instance *cfg_instance; > struct req_lib_cfg_killnode req_lib_cfg_killnode; > @@ -800,7 +800,7 @@ corosync_cfg_replyto_shutdown ( > cs_error_t corosync_cfg_get_node_addrs ( > corosync_cfg_handle_t cfg_handle, > int nodeid, > - int max_addrs, > + size_t max_addrs, > int *num_addrs, > corosync_cfg_node_address_t *addrs) > { _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
