On Tue, 2009-03-31 at 17:04 +0200, Jan Friesse wrote:
> Attached patch solves problem with ipc_log_printf, which calls
> _logsys_log_printf. Arguments for this function was va_list, so logged
> information was va_list address, instead of "what user wants".
>
> Solution is based on adding new function _logsys_log_vprintf, which
> takes va_list as argument. Old _logsys_log_printf is implemented by new
> _logsys_log_vprintf (no code duplication).
>
> Another problem which patch fixing is, that old logsys_log_printf used
> vsprintf to static allocated buffer. This could cause buffer owerflow,
> so vsnprintf is used now.
You probably want to check _logsys_log_printf usage too for TOTEM.
See:
totem_config.totem_logging_configuration.log_printf =
_logsys_log_printf;
from exec/main.c.
Anyway the patch needs to be ported on top of the new logsys
infrastructure so please don't commit until the rework lands in SVN
(should happen soon).
Fabio
_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais
