Jim Meyering wrote: > There were some new warnings due to const mismatches > and one unused static declaration. > > This fixes the offenders. > > From 3cff529156719f6a7557a7133403aa80dabbc1c0 Mon Sep 17 00:00:00 2001 > From: Jim Meyering <[email protected]> > Date: Mon, 4 May 2009 10:35:59 +0200 > Subject: [PATCH] avoid new warnings > MIME-Version: 1.0 > Content-Type: text/plain; charset=utf-8 > Content-Transfer-Encoding: 8bit > > * votequorum.c: Avoid declaration of unused: ‘votequorum_instance_destructor’ ... > diff --git a/lib/votequorum.c b/lib/votequorum.c > index fd5a924..f76395a 100644 > --- a/lib/votequorum.c > +++ b/lib/votequorum.c > @@ -64,8 +64,6 @@ struct votequorum_inst { > votequorum_callbacks_t callbacks; > }; > > -static void votequorum_instance_destructor (void *instance); > - > DECLARE_HDB_DATABASE(votequorum_handle_t_db,NULL); > > cs_error_t votequorum_initialize (
The above is still needed. Here's a better way to fix the pointer mismatch problem, since we do want that msg parameter to remain "non const". Thanks to Fabio and Steven for the reminder on IRC. From e8651515dede5466da975d10bfac50d28a07fdb1 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[email protected]> Date: Mon, 4 May 2009 14:30:34 +0200 Subject: [PATCH] avoid 'incompatible pointer type' compiler warning * test/cpgverify.c (cpg_deliver_fn): Remove const. --- test/cpgverify.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/cpgverify.c b/test/cpgverify.c index 26b7400..7150c6f 100644 --- a/test/cpgverify.c +++ b/test/cpgverify.c @@ -57,7 +57,7 @@ static void cpg_deliver_fn ( const struct cpg_name *group_name, uint32_t nodeid, uint32_t pid, - const void *m, + void *m, size_t msg_len) { const struct my_msg *msg2 = m; @@ -65,7 +65,7 @@ static void cpg_deliver_fn ( hash_state sha1_hash; unsigned int i; - + printf ("msg '%s'\n", msg2->buffer); sha1_init (&sha1_hash); sha1_process (&sha1_hash, msg2->buffer, msg2->msg_size); -- 1.6.3.rc4.190.g4648 _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
