On Tue, 2009-05-12 at 21:44 -0700, Steven Dake wrote: > On Tue, 2009-05-12 at 20:38 +0200, Fabio M. Di Nitto wrote: > > On Tue, 2009-05-12 at 17:34 +0200, Jan Friesse wrote: > > > Sorry, > > > I forgot include patch. > > > > > > Jan Friesse wrote: > > > > This is side effect of gid-uid patch I'm working on. > > > > > > > > Patch handles situations, where: > > > > - File is bad -> no error message is written (because it's replaced > > > > AFTER parse_section) > > > > - No newline is in the end of file (yes I know, it's not proper text > > > > file, but ...) > > > > - Handle obscure OS, where line doesn't end with \n, but end with \r (I > > > > think MAC is that case) or \r\n (we know what is that case) > > > > > > > > Regards, > > > > Honza > > > > > > > > This same patch will need to be ported to openaisparser. > > > > Steven, maybe there is time to unify the two parsers and use some > > envvars to enable openais services instead of carrying around 2 almost > > identical loaders? > > > > Fabio > > > An environment variable already exists to load the openais services.
Yes the environment var you mention selects between coroparser and openaisparser. Those 2 are basically duplicated code with the only difference that the latter loads openais services. What I am suggesting is to collapse the two into one (called coroparser) and get it to check for another envvar (for example coroparser_load_openais_services) that's internal only and will make coroparser behave like openaisparser does now. aisexec will have to export a different variable set (not an issue here as it's very simple) with the benefit to kill a bunch of duplicated code. Fabio _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
