Committed revision 2391. Steven Dake wrote: > good for merge > > regards > -steve > > On Tue, 2009-08-18 at 17:54 +0200, Jan Friesse wrote: >> This patch set found_service_ver to NULL (exec/service.c >> corosync_service_defaults_link_and_init) so if we don't find ver in >> objdb, we don't read from uninitialized memory. >> >> Regards, >> Honza >> plain text document attachment (corosync-found_service_ver-null.patch) >> commit 37af5c2ad8ead51f8da44cddd37be8d0419aecca >> Author: Jan Friesse <[email protected]> >> Date: Tue Aug 18 16:26:22 2009 +0200 >> >> Fix found_service_ver handling >> >> Sometimes, when object_key_get doesn't return found_service_ver it >> doesn't change old value and this value is then used in atoi what >> will can cause fall of corosync. >> >> diff --git a/trunk/exec/service.c b/trunk/exec/service.c >> index 717b736..ea58efb 100644 >> --- a/trunk/exec/service.c >> +++ b/trunk/exec/service.c >> @@ -399,6 +399,8 @@ unsigned int corosync_service_defaults_link_and_init >> (struct corosync_api_v1 *co >> (void *)&found_service_name, >> NULL); >> >> + found_service_ver = NULL; >> + >> corosync_api->object_key_get (object_service_handle, >> "ver", >> strlen ("ver"), >> _______________________________________________ >> Openais mailing list >> [email protected] >> https://lists.linux-foundation.org/mailman/listinfo/openais >
_______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
