On Mon, Aug 31, 2009 at 03:46:11PM -0700, Steven Dake wrote: > Ryan > > Great work, although it would be easier to review patches in the future > if they were broken into smaller chunks.
Right. Sorry. > Few notes from review: > > [DEBUG] in log_printf is not needed. We know its a debug message by the > log level. Yes. This is a relic of old code where I was using LOGSYS_LEVEL_NOTICE and prepending the message with "[DEBUG]". Easy fix. > Also there are some regular printf statements in the code which should > be removed. > > Please remove the regular printfs and then merge. The "regular" printfs are in library code only. I thought we agreed it was ok to leave these in place until we finished with saftest. > On Mon, 2009-08-31 at 09:33 -0500, Ryan O'Hara wrote: > > Here is a massive patch for the OpenAIS Message Service. This patch > > includes many bug fixes and changes. These include: > > > > - Code to define mar types for MSG service (mar_msg.h). > > - Code to marshall between AIS and mar types (mar_msg.h). > > - Swab data structures in exec layer. > > - Various changes to IPC structures. > > - Implementation of saMsgMessageSendReceive. > > - Implementation of saMsgMessageReply and saMsgMessageReplyAsync. > > - Limit saMsgMessageOpen and saMsgMessageOpenAsync such that a queue > > can only be opened once. This change is responsible for many of of > > the other changes included in this patch, as there are places where > > they code can be simplified do to this limitation. > > > > As far as saftest is concerned, most test cases pass. There are a > > handful that fail, and most (if not all) are due to differences > > between B.01.01 and B.03.01 spec. That said, it is definitely > > worthwhile to re-run these tests. I've done only a quick saftest run > > agaist this service in order to flush out obvious bugs. > > > > Please report bugs, memory leaks, etc and I will fix them ASAP. > > > > Ryan > > > > > > _______________________________________________ > > Openais mailing list > > [email protected] > > https://lists.linux-foundation.org/mailman/listinfo/openais _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
