Looks good to me.
Thanks for taking care of it.
Fabio
On Thu, 2009-09-10 at 07:14 +1200, Angus Salkeld wrote:
> >
> > Ok can we revive 2 seconds the idea to add a string to the corosync exec
> > that explicitly mention what features are built into the binary/package?
> >
> > I think I suggested it a long time ago but never got around to do it.
> >
> > Something that can tell us if there is nss/small-memory/whatever feature
> > built in that is not selectable at runtime.
> >
> > It's a matter of a 2/3 lines change in configure.ac and a log_printf( in
> > the main exec and can spare us the trouble to figure out that 2 builds
> > are incompatible (if users doesn't know what binary packages he received
> > from whatever distro and they are not compatible between them).
> >
> > Fabio
>
> Here is a patch that does this.
>
> -Angus
>
> Index: exec/main.c
> ===================================================================
> --- exec/main.c (revision 2408)
> +++ exec/main.c (working copy)
> @@ -813,6 +813,7 @@
> corosync_mlockall ();
>
> log_printf (LOGSYS_LEVEL_NOTICE, "Corosync Cluster Engine ('%s'):
> started and ready to provide service.\n", VERSION);
> + log_printf (LOGSYS_LEVEL_INFO, "Corosync built-in features:"
> PACKAGE_FEATURES "\n");
>
> (void)signal (SIGINT, sigintr_handler);
> (void)signal (SIGUSR2, sigusr2_handler);
> Index: configure.ac
> ===================================================================
> --- configure.ac (revision 2410)
> +++ configure.ac (working copy)
> @@ -420,6 +420,8 @@
> AC_SUBST([COROSYSCONFDIR])
> AC_DEFINE_UNQUOTED([COROSYSCONFDIR], "$(eval echo
> ${COROSYSCONFDIR})", [corosync config directory])
>
> +AC_DEFINE_UNQUOTED([PACKAGE_FEATURES], "${PACKAGE_FEATURES}",
> [corosync built-in features])
> +
> AC_OUTPUT
>
> AC_MSG_RESULT([])
> _______________________________________________
> Openais mailing list
> [email protected]
> https://lists.linux-foundation.org/mailman/listinfo/openais
_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais
