Hi,

Even after disabling timestamp in syslog, I still have this issue. I
attached the stack trace of aisexec process. I found two issues in openais
code.

   1. The openais has log_mode_mutex to allow only one thread to call
   syslog. This is used for pthread_atfork() to block two calling syslog. But
   clearly as we can see from the trace, two threads(thread 1 and 2) called
   log_printf_worker_fn() at the same time, so two threads called syslog() at
   the same time, that caused seg fault. If log_mode_mutex is moved to
   log_printf_worker_fn() from _log_printf, it can be prevented, so no seg
   fault
   2. When thread 2 had a seg fault, it calls seg fault signal handler
   sigsegv_handler(). The signal handler calls syslog again and it never
   return. I read an artical about the syslog is not a safe function for signal
   handler and it should not used insde signal handler. So if syslog is removed
   in the signal handler, the this signal handler can return. Then at least the
   deadlock may be avoided.

This is one of serious issue for our product development using
pacemaker/openais, so I want to reslve this issue as soon as possible.

Thank you
hj

On Mon, Dec 7, 2009 at 2:21 AM, Fabio M. Di Nitto <[email protected]>wrote:

> Jan Friesse wrote:
> > Fabio M. Di Nitto wrote:
> >> Jan Friesse wrote:
> >>> Included is patch removing strftime and replace it:
> >>> - first version with ISO style date format (2009-11-04 10:40:40 ...)
> >>> - second version with output similar to what we have now (Dec 04 ...)
> >>>
> >>> Choose what you prefer more.
> >>
> >> we need to be consistent with the current format. There is no choice
> there.
> >>
> >> Fabio
> >
> > we *Need*? Why?
> >
>
> because we need to be consistent as that same format is used by all
> applications in the cluster stack and not just corosync.
>
> Fabio
> _______________________________________________
> Openais mailing list
> [email protected]
> https://lists.linux-foundation.org/mailman/listinfo/openais
>



-- 
Dream with longterm vision!
kerdosa
_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais

Reply via email to