On Sun, Feb 07, 2010 at 09:42:44AM +0100, Fabio Massimo Di Nitto wrote: > On 2/6/10 10:15 PM, Ryan O'Hara wrote: > > > > Two of the message service API calls related to capacity thresholds > > had incorrect names. These API calls were named: > > > > saMsgQueueCapacityThresholdSet > > saMsgQueueCapacityThresholdGet > > > > The correct API calls are: > > > > saMsgQueueCapacityThresholdsSet > > saMsgQueueCapacityThresholdsGet > > > > This patch correct the naming of the API calls and, to be complete, > > changes the names of the related IPC request/response structures. > > Hi Ryan, > > this is a really unfortunate change because it means changing the > externally exported API.
It is not unforunate. It is a needed fix. > To make it really clean, you need to bump the soname version for > libSAmsg _or_ as an alternative, keep the old and the new name. This way > the old symbols will resolve and the new ones are available without > rebuild pain. Supporting both sets of API calls is not an option -- we're only going to use the correct API calls. This will go into effect when 1.2.0 is released. I'm open to patches for bumping lib versions. > We also need to make sure if we have users around for this API and > notify them of the name change (if you decide to not provide the old > symbols). Notify users? If people were using MSG service, we'd have already heard about this issue. Anyway, MSG service is fairly new API and these calls are 1) specific to B.03.01 specification and 2) mostly useless since capacity thresholds work by way of the notification service, which we don't have. Ryan _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
