I only have a few comments, some of them we discussed on IRC. When adding new files, you need to update the corosync.spec.in too. In general my policy has always been that (s)rpm from development should enable all features and ships all files.
Since those files are useful only when augtool are available, I suggest you create a separate binary rpm to ship them (call it corosync-augeas for example) that will Requires: augeas as dependency. This way, it´s clear what those files do, they don´t interfere with normal packaging, and they become optionally installable even in testing. Fabio On 2/16/2010 10:54 PM, Angus Salkeld wrote: > On Tue, 2010-02-16 at 07:09 -0700, Steven Dake wrote: >> The patch looks great but I prefer a feature addition as well: >> >> configure --enable-augeas option which has the effect of enabling the >> installation of the augeas files. >> > > Hi > > Attached is a patch with the --enable-augeas config option. > > -Angus > > >> On systems where there is no augeas, I'd wonder what would happen with >> this patch. >> >> Regards >> -steve >> >> On Tue, 2010-02-16 at 13:09 +1100, Angus Salkeld wrote: >>> Hi >>> >>> This adds an augeas lens to corosync (so you can configure corosync.conf >>> via augtool and python-augeas). >>> >>> Here is my post to the augeas ML. >>> https://www.redhat.com/archives/augeas-devel/2010-February/msg00041.html >>> >>> I have included rules to install the lens as the augeas maintainer suggests >>> (Steve I am not sure if that is what you want). >>> Note on my system I have the following >>> ls /usr/share/augeas/lenses/ >>> corosync.aug dist libvirtd.aug libvirtd_qemu.aug tests >>> >>> >>> The test suite I will post soon needs this to configure corosync. >>> >>> -Angus >>> >>> >>> _______________________________________________ >>> Openais mailing list >>> [email protected] >>> https://lists.linux-foundation.org/mailman/listinfo/openais _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
