On Wed, Feb 17, 2010 at 12:59:20PM -0700, Steven Dake wrote: > ya looks good for commit makes sense to add it to list after the > callback completes rather then before any work is done in the service > engine :)
Right. The problem presented itself when I created a test that called saMsgQueueClose in the callback handler for saMsgQueueOpenAsync. The queue_id was not added to the queueInstance until the API call returned. Upon further investigation, it only makes sense that a queueInstance is not valid until we're the callback is processed. This fix is committed in revision 2120. Ryan > On Wed, 2010-02-17 at 11:44 -0600, Ryan O'Hara wrote: > > Here is a patch that fixes the behavior of the callback generated by a > > saMsgQueueOpenAsync. The existing code contains two problems: > > > > 1. The queue_id should be send as part of the callback request, not > > returned in the response structure for the open async API call. This > > allows us to copy the queue_id into the queueInstance in the callback > > handler (saMsgDispatch). > > > > 2. A new queueInstance that is created as via an saMsgQueueOpenAsync > > call should not be valid until the corresponding callback has been > > processed. The saMsgDispatch code should insert the new queueInstance > > into the list contained within msgInstance. The existing code handled > > this list insertion in the API call, after we recieved a reponse. > > > > Ryan > > > > _______________________________________________ > > Openais mailing list > > [email protected] > > https://lists.linux-foundation.org/mailman/listinfo/openais _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
