I attached new patch with tap. Another question: I am using a wireshark packet dissector for corosync totem protocol downloaded from internet, that was very useful tool! But I found a few issues, is the original creator(from redhat) still maintaining that?
Thanks hj On Wed, Feb 17, 2010 at 3:14 PM, Steven Dake <[email protected]> wrote: > This patch looks good but uses spaces instead of tabs > > could you rework and resend and then I'll merge > > regards > -steve > > On Thu, 2010-02-04 at 22:47 -0700, hj lee wrote: > > Sorry, missed the attachment. > > > > hj > > > > On Thu, Feb 4, 2010 at 10:46 PM, hj lee <[email protected]> wrote: > > Hi, > > > > It's very minor patch to initialize encapsulated to 0 in > > hold_cancel message. Without this patch, encapsulated byte has > > a garbage byte that makes wireshark dissector fail. > -- Peakpoint Service Cluster Setup, Troubleshooting & Development [email protected] (303) 997-2823
Index: exec/totemsrp.c =================================================================== --- exec/totemsrp.c (revision 2659) +++ exec/totemsrp.c (working copy) @@ -2615,6 +2615,7 @@ */ token_hold_cancel.header.type = MESSAGE_TYPE_TOKEN_HOLD_CANCEL; token_hold_cancel.header.endian_detector = ENDIAN_LOCAL; + token_hold_cancel.header.encapsulated = 0; token_hold_cancel.header.nodeid = instance->my_id.addr[0].nodeid; memcpy (&token_hold_cancel.ring_id, &instance->my_ring_id, sizeof (struct memb_ring_id));
_______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
