On Mon, 2010-02-22 at 11:11 -0600, David Teigland wrote: > On Mon, Feb 22, 2010 at 06:00:21PM +0100, Jan Friesse wrote: > > Related to https://bugzilla.redhat.com/show_bug.cgi?id=529424 > > > > Patch implements new callback with current totem ring id and members. > > Included is modified testcpg using functionality. As required, callback > > is delivered AFTER all normal confchg callbacks. > > > > Patch is not 100% tested (specially big endian issues and > > whitetank/older versions of corosync coexistence) but looks stable. > > > > David, fulfill that functionality your requirements? > > Thanks Honza! This looks like it will do well, but I can't be certain > until I work through the implementation and testing to use this on my end. > I'll try to get working on that soon so I can let you know. > Dave >
Dave, Just to clarify here, this may not be the final implementation we go with but what we end up with should be close. There are ABI issues with this patch. For example, someone could compile code against the old headers, and then cpg_dispatch might segfault from random garbage data at the end of the new callback structure. I spoke with Honza, and we came up with the concept of a new initialize function. Essentially it would work like this: error = cpg_initialize_model (&handle, CPG_MODEL_V2, &model_data); This API call would deprecate cpg_initialize (although cpg_initialize would still be supported using the current two callbacks we have). By using this mechanism, we can specify a consistent set of callbacks per MODEL version, and cpg_dispatch will do the right thing depending on the value of model for the cpg instance and the settings of model_data. This allows us to make changes in the model the API presents without impacting existing users of cpg. We will wait to do this model suggestion until we have come to conclusion that Honza's curent solution works for you. The impact should be fairly minimal (changing your cpg_initialize to cpg_initialize_model). > _______________________________________________ > Openais mailing list > [email protected] > https://lists.linux-foundation.org/mailman/listinfo/openais _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
