Hello,

I tried to use the flatiron branch of Corosync yesterday at home, and I got a tiny problem: It appears that the default value for the consensus timeout parameter doesn't pass its check in exec/totemconfig.c:L562. I had a look in the trunk version, and it seems to be fixed in this one.

I've joined the configuration file I used and the tiny patch I applied to fix this problem.
totem {
        version: 2
        nodeid: 1
        threads: 0
        secauth: off
        vsftype: none
        heartbeat_failures_allowed: 0
        max_network_delay: 50
        interface {
                ringnumber: 0
                mcastaddr: 226.94.1.1
                mcastport: 5405
                bindnetaddr: 192.168.56.0
        }
}

logging {
        to_stderr: yes
        to_logfile: yes
    logfile: /var/log/corosync.log
        timestamp: off
        debug: on
}
diff --git a/exec/totemconfig.c b/exec/totemconfig.c
index de02c77..aa54ad3 100644
--- a/exec/totemconfig.c
+++ b/exec/totemconfig.c
@@ -559,7 +559,7 @@ int totem_config_validate (
 		goto parse_error;
 	}
 
-	if (totem_config->consensus_timeout <= 1.2 * totem_config->token_timeout) {
+	if (totem_config->consensus_timeout < 1.2 * totem_config->token_timeout) {
 		snprintf (local_error_reason, sizeof(local_error_reason),
 			"The consensus timeout parameter (%d ms) must be atleast 1.2 * token (%d ms).",
 			totem_config->consensus_timeout, (int) ((float)1.2 * totem_config->token_timeout));
_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais

Reply via email to