On Sun, May 16, 2010 at 11:43:26AM -0700, Steven Dake wrote: > On Sun, 2010-05-16 at 18:40 +1000, Angus Salkeld wrote: > > backlog is unsigned > >
Changed & Committed. > > Signed-off-by: Angus Salkeld <[email protected]> > > --- > > exec/totemsrp.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/exec/totemsrp.c b/exec/totemsrp.c > > index 3d8bd05..a7818b4 100644 > > --- a/exec/totemsrp.c > > +++ b/exec/totemsrp.c > > @@ -3299,7 +3299,6 @@ static void fcc_token_update ( > > { > > token->fcc += msgs_transmitted - instance->my_trc; > > token->backlog += instance->my_cbl - instance->my_pbl; > > - assert (token->backlog >= 0); > > instance->my_trc = msgs_transmitted; > > instance->my_pbl = instance->my_cbl; > > } > > @@ -3416,6 +3415,9 @@ static int message_handler_orf_token ( > > > > case MEMB_STATE_OPERATIONAL: > > messages_free (instance, token->aru); > > + /* > > + * fall through > > + */ > > not to be too picky but :) this comment isn't very good. Maybe > something like > "Do NOT add break, this case should also execute code in gather case. > > Regards > -steve > > case MEMB_STATE_GATHER: > > /* > > * DO NOT add break, we use different free mechanism in > > recovery state _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
