Kacper,
I believe the consensus is that LDFLAGS should be honored as per your
analysis. Can you rework your patch to address just that point?
I believe the remaining point (--disable-optimization) is already
addressed by --enable-debug. If I am in error here, please let me know.
Thanks
-steve
On 08/25/2010 02:16 AM, Kacper Kowalik wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> W dniu 25.08.2010 10:37, Fabio M. Di Nitto pisze:
>> On 8/25/2010 10:26 AM, Kacper Kowalik wrote:
>>> Hi,
>>> I would like to ask for inclusion regarding two issues:
>>> 1) respect LDFLAGS env during linking
>>
>> this is good one, did you check if all Makefiles.am do respect LD_FLAGS
>> already? If not, the change should probably be more global.
>
> Yup, that's all I found. You can verify this by:
> 1. export LDFLAGS=-Wl,--hash-style=gnu
> 2. build
> 3. scanelf -qyRF '%k %p' -k .hash ${BUILDIR} | sed -e "s:\.hash ::"
>
>>> 2) don't enforce any optimization/debug flags by default
>>
>> hmm I disagree here.
>>
>> -O3 is necessary to obtain performance out of the sober crypto code. I
>> recall a major impact in performance with anything lower than that.
> Remember that setting no flags is eqv. to -O2, but it doesn't matter here.
> If you have a set of flags that you consider as "best" for your package
> please use them. Make them even default. I only ask for a possibility to
> switch them off, e.g. by --disable-optimization. This way it won't
> change current behaviour of openais at all and will suite my needs.
> Best regards,
> Kacper Kowalik
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.16 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iJwEAQECAAYFAkx033QACgkQIiMqcbOVdxQFKgQAjuwLD5NjdmQT5dfdFeYshzkh
> 2dTKyx+i9SO99RuBWCH6qqZODkwD5Cb6/cpuIAvFT8cJgvEGDVBpW3UenXBqZnQL
> eFeik84uMQs0s2Srsj1dxJBUPIxJL7o/uE8P4BnkahpabqyKhKPm2+Yqyi4fla0m
> 3lYU92oAtLhDCFmkmI0=
> =FnK2
> -----END PGP SIGNATURE-----
> _______________________________________________
> Openais mailing list
> [email protected]
> https://lists.linux-foundation.org/mailman/listinfo/openais
_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais
