On 02/22/2011 12:38 PM, dan clark wrote: > Hi Steve et al. > Please consider the following patch to coroipcc to reduce the stack > size required by clients. > Thanks, > dan > > > > _______________________________________________ > Openais mailing list > [email protected] > https://lists.linux-foundation.org/mailman/listinfo/openais
Dan, I'm not opposed to this patch, but it doesn't apply cleanly with the patch command (garbage input file). Noticing we don't have a real clear description of how patches should be submitted, I wrote some instructions: http://www.corosync.org/doku.php?id=dev:submitting_patches If that looks like too much work, get me a patch with a proper diff output (diff -uNr file1.c file2.c) and I'll follow the git methods above. Also, I notice there is code that does something like if (setup) free (setup) free (NULL) is a noop on POSIX and checking the value of setup is not necessary. A free (setup) will do. Regards -steve _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
