On 02/23/2011 05:35 AM, Jan Friesse wrote:
> Steven Dake wrote:
>> On 02/22/2011 02:52 AM, Jan Friesse wrote:
>>> Signed-off-by: Jan Friesse <[email protected]>
>>> ---
>>>  tools/corosync-fplay.c |    4 ++--
>>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tools/corosync-fplay.c b/tools/corosync-fplay.c
>>> index 57e6f97..a1aedd9 100644
>>> --- a/tools/corosync-fplay.c
>>> +++ b/tools/corosync-fplay.c
>>> @@ -502,8 +502,8 @@ int main (void)
>>>     }
>>>  
>>>     if (n_read != n_required) {
>>> -           printf ("Warning: read %lu bytes, but expected %lu\n",
>>> -                   (unsigned long) n_read, (unsigned long) n_required);
>>> +           printf ("Warning: read %zd bytes, but expected %zu\n",
>>> +                   n_read, n_required);
>>>     }
>>>  
>>>     rec_idx = flt_data[FDTAIL_INDEX];
>>
>> Not sure what the state of %z modifier is in various libcs floating
>> around.  I know it is defined by C99 and also works well in glibc, but I
>> am curious about other OS platforms.  Can you give a quick run on bsd of
>> some type, and if works there, then good for commit
>>
>> Reviewed-by: Steven Dake <[email protected]>
> 
> Actually according documentation (man pages):
> MAC OS X since 10.3 (I was not able to find older)
> NetBSD has this since 1.6
> FreeBSD since 5.0
> OpenBSD since 3.8
> 
> I'm pretty sure that OpenBSD has this feature for much longer time.
> 
> So every systems about 10-11 years old. I've committed patch, and will
> see if somebody will start complain.
> 
> Regards,
>   Honza

thanks for the follow-up.

_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais

Reply via email to