On 03/21/2011 08:39 AM, Jan Friesse wrote:
> One nitpick included. If fixed or my misunderstanding then ok to go.
>
> Steven Dake napsal(a):
>>
>> @@ -1550,6 +1554,7 @@ static void timer_function_orf_token_timeout
>> (void *data)
>> totemrrp_iface_check (instance->totemrrp_context);
>> memb_state_gather_enter (instance, 2);
>> instance->stats.operational_token_lost++;
>> + instance->orf_token_discard = 1;
>> break;
>>
>> case MEMB_STATE_GATHER:
>
> ^^^^^ THIS seems to be not needed because it done in
> memb_state_gather_enter \/
>
>> @@ -1823,6 +1829,8 @@ static void memb_state_gather_enter (
>> struct totemsrp_instance *instance,
>> int gather_from)
>> {
>> + instance->orf_token_discard = 1;
>> +
>> memb_set_merge (
>> &instance->my_id, 1,
>> instance->my_proc_list, &instance->my_proc_list_entries);
>
> Reviewed-by: Jan Friesse <[email protected]>
>
Thanks,
I was following the spec from her PHD, but your right it is not necessary
Regards
-steve
_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais
