Reviewed-by: Steven Dake <[email protected]> Thanks for the patch!
On 04/14/2011 05:40 PM, Tim Serong wrote: > Without refcounting the conn pointer here, corosync will segfault > if one kills a running instance of "corosync-cfgtool -r" (rhbz#695191) > > Signed-off-by: Tim Serong <[email protected]> > --- > services/cfg.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/services/cfg.c b/services/cfg.c > index 950f2e9..b7aa63b 100644 > --- a/services/cfg.c > +++ b/services/cfg.c > @@ -584,6 +584,8 @@ static void message_handler_req_exec_cfg_ringreenable ( > req_exec_cfg_ringreenable->source.conn, > &res_lib_cfg_ringreenable, > sizeof (struct res_lib_cfg_ringreenable)); > + > + api->ipc_refcnt_dec(req_exec_cfg_ringreenable->source.conn); > } > LEAVE(); > } > @@ -704,6 +706,7 @@ static void message_handler_req_lib_cfg_ringreenable ( > req_exec_cfg_ringreenable.header.id = SERVICE_ID_MAKE (CFG_SERVICE, > MESSAGE_REQ_EXEC_CFG_RINGREENABLE); > api->ipc_source_set (&req_exec_cfg_ringreenable.source, conn); > + api->ipc_refcnt_inc(conn); > > iovec.iov_base = (char *)&req_exec_cfg_ringreenable; > iovec.iov_len = sizeof (struct req_exec_cfg_ringreenable); _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
