Looks good.
Reviewed-by: Angus Salkeld <[email protected]>
On Wed, May 04, 2011 at 05:27:11PM +0200, Jan Friesse wrote:
> memb_state_gather_enter increase stats.continuous_gather only if
> previous state was gather also. This should happen only if multicast is
> not working properly (local firewall in most cases) and not if many
> nodes joins at one time.
> ---
> exec/totemsrp.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/exec/totemsrp.c b/exec/totemsrp.c
> index d300d4b..9f7f434 100644
> --- a/exec/totemsrp.c
> +++ b/exec/totemsrp.c
> @@ -1895,7 +1895,13 @@ static void memb_state_gather_enter (
>
> instance->memb_state = MEMB_STATE_GATHER;
> instance->stats.gather_entered++;
> - instance->stats.continuous_gather++;
> +
> + if (gather_from == 3) {
> + /*
> + * State 3 means gather, so we are continuously gathering.
> + */
> + instance->stats.continuous_gather++;
> + }
>
> if (instance->stats.continuous_gather > MAX_NO_CONT_GATHER) {
> log_printf (instance->totemsrp_log_level_warning,
> --
> 1.6.2.5
>
> _______________________________________________
> Openais mailing list
> [email protected]
> https://lists.linux-foundation.org/mailman/listinfo/openais
_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais
