On 05/18/2011 06:27 AM, Jerome Flesch wrote:
> ---
> lib/coroipcc.c | 15 +++++++++++++--
> 1 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/lib/coroipcc.c b/lib/coroipcc.c
> index 34db980..c03925c 100644
> --- a/lib/coroipcc.c
> +++ b/lib/coroipcc.c
> @@ -847,6 +847,17 @@ coroipcc_dispatch_get (
> return (error);
> }
>
> + if (shared_mem_dispatch_bytes_left (ipc_instance) >
> (ipc_instance->dispatch_size/2)) {
> + /*
> + * Notify coroipcs to flush any pending dispatch messages
> + */
> + res = ipc_sem_post (ipc_instance->control_buffer,
> SEMAPHORE_REQUEST_OR_FLUSH_OR_EXIT);
> + if (res != CS_OK) {
> + error = CS_ERR_LIBRARY;
> + goto error_put;
> + }
> + }
> +
> *data = NULL;
>
Could you explain this change in more detail? These types of semaphores
should only be triggered during a request, or a flush should happen, or
we should exit.
Regards
-steve
> ufds.fd = ipc_instance->fd;
> @@ -874,11 +885,11 @@ coroipcc_dispatch_get (
> error = socket_recv (ipc_instance->fd, &buf, 1);
> assert (error == CS_OK);
>
> - if (shared_mem_dispatch_bytes_left (ipc_instance) > 500000) {
> + if (shared_mem_dispatch_bytes_left (ipc_instance) >
> (ipc_instance->dispatch_size/2)) {
> /*
> * Notify coroipcs to flush any pending dispatch messages
> */
> -
> +
Can you remoe this whitespace change and submit this change as a
separate patch. Then it should be suitable for merging.
> res = ipc_sem_post (ipc_instance->control_buffer,
> SEMAPHORE_REQUEST_OR_FLUSH_OR_EXIT);
> if (res != CS_OK) {
> error = CS_ERR_LIBRARY;
_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais
