Steven Dake wrote: > On 06/01/2011 09:14 AM, Jan Friesse wrote: >> In this concrete case result is equivalent but makes coverity happy. >> >> Signed-off-by: Jan Friesse <[email protected]> >> --- >> services/cpg.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/services/cpg.c b/services/cpg.c >> index a0336ed..cb1102f 100644 >> --- a/services/cpg.c >> +++ b/services/cpg.c >> @@ -996,7 +996,7 @@ static void do_proc_join( >> } >> list_to_add = list; >> } >> - list_splice (&pi->list, list_to_add); >> + list_add (&pi->list, list_to_add); >> >> notify_info.pid = pi->pid; >> notify_info.nodeid = nodeid; > > please test this carefully - whenever a list_splice is used in cpg, it > was used for a reason (to fix a defect).
I've tested all patches really carefully. I don't understand why coverity thinks that list_splice is incorrect. list_add works there without any problem because we are adding only one item to list (not the list). _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
