On 2011-06-29 19:07, Steven Dake wrote: > Couple nitpicky things inline. Otherwise looks absolutely stellar. I > ran the changes through coverity and all looks good there. > > I saw on earlier post on this thread this code was not yet tested. > > Since this is such a signficant change in a stable tree, I'd like two > tested-by signoffs not by the original authors of the patch work. Honza > and Angus would be good choices. Testing in a virtual machine cluster > is acceptable.
I have tested this patch and it appears to be working fine for me. Test
setup was two KVM virtualized CentOS 5.6 nodes with Corosync RPMs built
from current HEAD plus your patch applied.
Relevant portion of corosync.conf as follows:
rrp_mode: active
interface {
ringnumber: 0
bindnetaddr: 192.168.122.0
mcastaddr: 239.0.42.1
mcastport: 5405
ttl: 1
}
interface {
ringnumber: 1
bindnetaddr: 192.168.133.1
mcastaddr: 239.0.42.2
mcastport: 5405
ttl: 1
}
Enabled services: Pacemaker
Testing procedure:
* Start Corosync & Pacemaker
* Wait for crm_mon to list both nodes as online
* Use brctl delif in host environment to "pull virtual cord" on guest eth0
* Observe corosync-cfgtool in both guests, watch problem counter
increment and ring eventually turning to FAULTY
* Use brctl delif to reinstate network connectivity
* Observe corosync-cfgtool returning ring to "no faults" state within 1
second
* Repeat for other interface
This is all very, very cool. Thanks very much for putting your effort
into this.
I have applied your patch to the "rr-recovery" branch in my Github
clone; whoever is interested may take a look here:
https://github.com/fghaas/corosync/tree/rr-recovery
I'll add revised versions of your patch to this branch as you submit
them, and will rebase the branch against master occasionally. Or else,
maybe Steve wants to pull into a topic branch on corosync.org.
Cheers,
Florian
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
