On 2011-07-06 15:59, Steven Dake wrote: > On 07/06/2011 06:56 AM, Florian Haas wrote: >> On 2011-07-06 15:49, Steven Dake wrote: >>> Florian, >>> >>> I'll take improvements however I can get them, but sending patches to >>> the list is preferred that way multiple people can look at them. >> >> Arguably that counts for github too, as my repo happens to be quite >> public. :) >> >>> The way I generally do this is >>> >>> git send-email [email protected] --smtp-server=server -3 >>> >>> where -3 is last 3 patches >>> >>> the to and smtp server can be set in gitconfig as well. >> >> Fair enough, but do you actually prefer to "git am" each patch by hand? >> Wouldn't it make more sense to post the patches first, when reviewed and >> acknowledged fix up the git tree so you can merge easily, and then send >> a pull request? >> > > I do like git am, however, open to changes. > > I am not sure how to amend a commit in a patch set to include a > reviewed-by line. Get am lets me amend per patch. Any tips here?
Hmmm. You can merge from my repo into yours, then use "git rebase -i <base rev>" to edit commit messages and add your Reviewed-By lines. But the downside of this is that this creates in place of my changesets it creates new ones, and then I have to reset my tree to match yours after you've pushed your changes. I think normally what's most often done is the contributor posts patches first, gets review and testing feedback, then the _contributor_ adds Reviewed-By, Tested-By, etc., issues a pull request, and then the maintainer pulls, and no further changes to the commits are necessary. Does that sound workable? Florian
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
