On Jan 23, 2010, at 12:31 AM, Jeremy Murphy wrote:
> I originally posted this to the discussion list, so I thought I should post
> it
> here where it is more appropriate.
Out of curiosity, I see it's licensed as:
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation version 2 of the License.
Is there are reason you have it only under version 2? I know
the OB is GPLv2 only, because of OpenEye's original license,
but I suspect authors of new code should consider "v2 or later."
I looked a few other parts of the code. Were it me I would fix
up some of the comments, like have
//To use an output option
become
// To use an output option
I also like code which fits into 80 columns, but I realize
that both this and the previous comment of mine are more
personal preferences, and not an OB standard convention.
I'm curious about if you've resolved this comment:
// Will this need to recurse here? (Or does atomic numbering take care of
that?)
I looked at the URLs but couldn't find the format definitions.
Do you have examples, which could be added to the test cases?
> Is there anything else I need to do so that it is accepted? Thanks, cheers.
BTW, I have absolutely no saw into these matters. :)
Andrew
[email protected]
------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
OpenBabel-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbabel-devel
