2011/1/15 Konstantin Tokarev <annu...@yandex.ru>: > >>> I've also experienced visibility issues with OpenBabel compiled using >>> Intel Compiler on Linux >> >> Can you be more specific? In all honesty, if the public API is not >> well defined and people are experiencing issues this should be an >> option that defaults to off at best. Like I said, the work Chris and >> others had done to get things working on Windows made me think that >> the work to change the visibility defaults in GCC would be minimal. > > Enabling visibility resulted in 5 failing tests: > http://my.cdash.org/viewTest.php?onlydelta&buildid=54009 > Maybe compiler bug though > >> All the flag does is change default visibility to hidden, I don't use >> the Intel compiler but I assume it does a very similar thing. > > Yes, and it has the same syntax as in GCC > I just committed r4365, this adds a new option for ENABLE_SYMBOL_VISIBILTY, and it defaults to OFF. If turned on GCC/Intel symbol visibility will be used, but left off it will be as in the autotools build system. If there are no objections I would prefer to at least retain the option to turn this on so that we can enable it where it works, and possibly fix any remaining issues in the future so that it could default to ON.
Marcus ------------------------------------------------------------------------------ Protect Your Site and Customers from Malware Attacks Learn about various malware tactics and how to avoid them. Understand malware threats, the impact they can have on your business, and how you can protect your company and customers by using code signing. http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ OpenBabel-Devel mailing list OpenBabel-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-devel
