S , 2011-10-08 17:45 +0100, Chris Morley rakstīja: > On 08/10/2011 17:07, My Th wrote: > > Hi! > > > > I have posted a patch (3411037) in tracker for plugin loading which > > moves the plugin loading away from OBConversion constructor and loads > > them instead on first access. I would like to get some feedback on it. > > > > The use case for this is when the molecule is constructed in a program > > without the use of OBConversion and one wants to generate 3D coordinates > > or optimize the structure using some MM forcefield. > > > > Now one has to guess that OBConversion constructor has to be called > > before searching for forcfield regardless if the OBConversion is > > actually needed at that point or not. > > > > With the proposed patch all plugins will be loaded when they are > > accessed for the first time. So there is no need for any extra action > > from the user. > > > > This patch doesn't change OB behavior in any incompatible way as far as > > I can tell and it is in line with the lazy evaluation idea. > > > > So, is this approach ok? Is there anything I'm missing? Will it be in > > 2.3.1? :) > > No, 2.3.1 happens next week and it is too late to introduce this quite > large change. Nor am I sure that it would be binary compatible with the > previous version, which we try to do for a minor version update. > However, the mod does look worthwhile for the next version and I'll try > to add it later.
Thanks for looking at it! As far as I know it should not break binary compatibility, but I might be wrong. I hope this change gets in eventually in one form or another. Reinis ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2dcopy2 _______________________________________________ OpenBabel-Devel mailing list OpenBabel-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-devel
