> right; I had overlooked that issue. Please find attached a better patch which > keeps both API and ABI backward compatibility, while avoiding new #defines > for special flags. What I did was keeping the same prototype for > AddHydrogens, while transforming it in a wrapper for a new function, > AddPolarNonPolarHydrogens().
Please don't. Why don't you do something like: AddNewHydrogens(enum HydrogenType = All, PolarOnly, NonPolarOnly); > The latter accepts two bool arguments, addpolar and addnonpolar: The problem with bool arguments is that they're unclear. If I forget the order, I get totally unexpected behavior. > - false, false will do nothing Case in point, no one would call the method expecting nothing to happen. So using an enum is a much better option here. So I'd suggest adding a new method with an enum for both adding/deleting as you suggest. Best regards, -Geoff ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ OpenBabel-Devel mailing list OpenBabel-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-devel
