On 03/06/2012 17:58, Geoff Hutchison wrote: >> Right, it came in C++ from C and should be in most compilers now. I also >> think that this is the best option. I'll write a patch for it. Only I'm >> reading that inttypes.h is not available for VS2003-2008, do we need a >> workaround for them? If so, maybe it is better to just define uint32_t >> myself. > > I think it's safe to say that VS2003-VS2008 are compiling for 32-bit Windows. > Maybe Chris can comment if 64-bit Windows uses 64-bit integers.
Noel has a 64 bit Windows build, which is on the dashboard and may or may not appear in the release. 64 bit builds with Visual Studio use a 32 bit int. Chris > #ifndef uint32_t > #define … > #endif > >> One more question - would it make sense to use uint64_t on 64bit >> platforms? Probably not without benchmarking. > > I wouldn't bother. > >> Yeah, to find optimal solution probably would require to write different >> implementations and benchmark them for different scenarios. I might look >> into this if I find time. > > > I think there are probably bigger things to tackle, which is why I've > generally left bitvec alone -- it clearly works fairly well. So I'd rather > concentrate on the chemistry code. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ OpenBabel-Devel mailing list OpenBabel-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-devel
