Yes - it does. That's great. I've commited it in r4869.
- Noel
On 9 June 2012 16:05, My Th <rei4...@gmail.com> wrote:
> S , 2012-06-09 14:59 +0100, Noel O'Boyle rakstīja:
>> Hi Reinis,
>>
>> Your r4832 ("conformersearch.h: Fix -Wdelete-non-virtual-dtor") is
>> causing a warning when compiling the bindings with MSVC.
>>
>> 1>C:\Tools\openbabel\trunk\include\openbabel/conformersearch.h(65) :
>> warning C4273: 'OpenBabel::OBConformerFilter::~OBConformerFilter' :
>> inconsistent dll linkage
>> 1> C:\Tools\openbabel\trunk\include\openbabel/conformersearch.h(62)
>> : see previous definition of '{dtor}'
>> 1>C:\Tools\openbabel\trunk\include\openbabel/conformersearch.h(167) :
>> warning C4273: 'OpenBabel::OBConformerScore::~OBConformerScore' :
>> inconsistent dll linkage
>> 1> C:\Tools\openbabel\trunk\include\openbabel/conformersearch.h(164)
>> : see previous definition of '{dtor}'
>>
>> - Noel
>
> Does moving dtor definitions (conformersearch.h::65 and
> conformersearch.h::167) to conformersearch.cpp helps?
>
>
> Reinis
>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
OpenBabel-Devel mailing list
OpenBabel-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-devel
