I was looking at this, and my only remaining concern is that the cairo and rpc directories could be included before that headers of the library you are going to link against - if they ever change the API this would cause problems (largely for Windows builds), as they look like snapshots of the headers of those libraries at some point in time.
It seems like the two headers in the root are providing C99 functionality Open Babel needs that is not provided by the MSVC compilers, with no library to link to. I think it would be better to separate the snapshots from the header only C99 functions, but if you really want to keep them together I can do that (and test it out). Marcus On Wed, Jul 24, 2013 at 3:19 PM, Chris Morley <c.mor...@gaseq.co.uk> wrote: > I don't understand enough of this to contribute much, but all the > components used to build with the Express versions of VS 2008, 2010, > 2012 and 2013 must be freely available and distributable. One prebuilt > binary that we would be better without is vcredist_x86.exe. > > Chris > > I On 24/07/2013 17:39, Noel O'Boyle wrote: >> It's all generic. If Chris agrees, I think we should just rename it to >> msvc as others do. The DLL locations are specified using CMake (or >> automatically found if unspecified) so no-one is tied to using our >> prebuilt ones. >> >> - Noel >> >> On 24 July 2013 17:33, Marcus D. Hanwell <marcus.hanw...@kitware.com> wrote: >>> I don't know how generic the other headers are, or if they are tied to >>> particular DLLs. I don't want to be tied to the prebuilt binaries, and >>> so it seems like it might need some separation (assuming you want to >>> continue using prebuilt binaries). >>> >>> Marcus >>> >>> On Wed, Jul 24, 2013 at 12:07 PM, Noel O'Boyle <baoille...@gmail.com> wrote: >>>> Would renaming windows-vc2008 to msvc solve the problem? >>>> >>>> - Noel >>>> >>>> On 24 July 2013 15:57, Marcus D. Hanwell <marcus.hanw...@kitware.com> >>>> wrote: >>>>> Hi, >>>>> >>>>> We build Open Babel on Windows without prebuilt binaries, and have >>>>> tracked down an issue with the C99 headers and MSVC. The headers in >>>>> windows-vc2008/include/ don't seem to be Visual Studio 2008 specific, >>>>> if there are no objections could I move inttypes.h and stdint.h to >>>>> msvc-support or similar so that any MSVC compiler can have them added >>>>> to the include directories? We can put a patch together if this seems >>>>> reasonable - cairo and rpc seem to be tied to prebuilt binaries and I >>>>> would leave them where they are. >>>>> >>>>> Thanks, >>>>> >>>>> Marcus >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> See everything from the browser to the database with AppDynamics >>>>> Get end-to-end visibility with application monitoring from AppDynamics >>>>> Isolate bottlenecks and diagnose root cause in seconds. >>>>> Start your free trial of AppDynamics Pro today! >>>>> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >>>>> _______________________________________________ >>>>> OpenBabel-Devel mailing list >>>>> OpenBabel-Devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/openbabel-devel >> >> ------------------------------------------------------------------------------ >> See everything from the browser to the database with AppDynamics >> Get end-to-end visibility with application monitoring from AppDynamics >> Isolate bottlenecks and diagnose root cause in seconds. >> Start your free trial of AppDynamics Pro today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >> _______________________________________________ >> OpenBabel-Devel mailing list >> OpenBabel-Devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/openbabel-devel >> > > > ------------------------------------------------------------------------------ > See everything from the browser to the database with AppDynamics > Get end-to-end visibility with application monitoring from AppDynamics > Isolate bottlenecks and diagnose root cause in seconds. > Start your free trial of AppDynamics Pro today! > http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk > _______________________________________________ > OpenBabel-Devel mailing list > OpenBabel-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openbabel-devel ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ OpenBabel-Devel mailing list OpenBabel-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-devel
