On Tue, Oct 22, 2013 at 11:52:11AM -0400, David Hall wrote: > Let me know if you have any questions or see any problems with these > changes.
Hi! PYTHON_INSTDIR should be made user overridable and prefferably in the way that it is seen in ccmake when Python bindings are enabled. One usecase for it is Gentoo ebuilds which install in the sandbox before merging it on the system. The simplest patch which enables overriding is given below, but it should be improved to make the variable with the value from cmake visible in the ccmake menu. Reinis diff --git a/scripts/CMakeLists.txt b/scripts/CMakeLists.txt index e3f6032..13c3364 100644 --- a/scripts/CMakeLists.txt +++ b/scripts/CMakeLists.txt @@ -107,12 +107,14 @@ if (DO_PYTHON_BINDINGS) OUTPUT_NAME _openbabel PREFIX "" SUFFIX .so ) + if(NOT PYTHON_INSTDIR) execute_process( COMMAND ${PYTHON_EXECUTABLE} -c "from distutils import sysconfig; print(sysconfig.get_python_lib(1,0,prefix='${CMAKE_INSTALL_PREFIX}'))" OUTPUT_VARIABLE PYTHON_INSTDIR OUTPUT_STRIP_TRAILING_WHITESPACE ) + endif() if(NOT BINDINGS_ONLY) add_dependencies(bindings_python openbabel) endif() ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk _______________________________________________ OpenBabel-Devel mailing list OpenBabel-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-devel