I guess a third option is the ifdef the code out if you don't have eigen3 ,
similar to how  src/charges/qtpie.cpp is ifdefed out if you don't have
eigen at all.

That might make the most sense.

-David



On Fri, Feb 7, 2014 at 6:38 PM, David Hall <li...@cowsandmilk.net> wrote:

> Today I was installing from openbabel master for someone and noticed the
> newly added eqeq does not seem to be compatible with eigen2
>
> Specifically, lines 166 and 169 of charges/eqeq.cpp
>
>
> https://github.com/openbabel/openbabel/blob/master/src/charges/eqeq.cpp#L166
>
> The tail, head, and colPivHouseholderQr are not in eigen2
>
> I think there are two options:
> (1) drop eigen2 support. CMakeLists.txt can be changed to do this fairly
> easily.
> (2) make eigen2 compatible versions of those lines. I know nothing about
> eigen, so I cannot say how difficult that would be.
>
> Any thoughts?
>
> -David
>
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
OpenBabel-Devel mailing list
OpenBabel-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-devel

Reply via email to