Thanks for the super quick response. I do appreciate it. There is a std::isnan via _isnan build problem which will require a #define for particular MSVC versions, but that's nothing to do with my pull request.
Ok - I'm going to do ahead and silence the tests.... - Noel On 9 June 2017 at 13:56, Maciek Wójcikowski <mac...@wojcikowski.pl> wrote: > I'm getting different errors on current master, see > https://ci.appveyor.com/project/mwojcikowski/conda-openbabel/build/1.0.19 > I need to fix conda recipe for git master first, but I think we should merge > it as is and figure out what is the issue with tests later on. > > ---- > Pozdrawiam, | Best regards, > Maciek Wójcikowski > mac...@wojcikowski.pl > > 2017-06-09 14:23 GMT+02:00 Noel O'Boyle <baoille...@gmail.com>: >> >> I'm keen to get my code merged, so I'm going to press you on this. >> I've spent several months getting these tests to 100% passing. I'm >> happy to send a screenshot showing this on my Windows machine. >> >> - Noel >> >> On 6 June 2017 at 20:52, Noel O'Boyle <baoille...@gmail.com> wrote: >> > The link is on the PR: >> > https://ci.appveyor.com/project/baoilleach/openbabel/build/1.0.501 >> > >> > Ok - I'll wait until you confirm. >> > >> > - Noel >> > >> > On 5 June 2017 at 19:18, Maciek Wójcikowski <mac...@wojcikowski.pl> >> > wrote: >> >> We need to verify that it doesn't mess up the conda packages for >> >> windows. >> >> I'll have some time by the end of the week. >> >> >> >> PS. >> >> https://ci.appveyor.com/project/baoilleach/openbabel/build/1.0.481 this >> >> build says 100% tests passed. Am I looking at the wrong one? >> >> >> >> ---- >> >> Pozdrawiam, | Best regards, >> >> Maciek Wójcikowski >> >> mac...@wojcikowski.pl >> >> >> >> 2017-06-05 19:17 GMT+02:00 Noel O'Boyle <baoille...@gmail.com>: >> >>> >> >>> Hey Geoff, >> >>> >> >>> I'm going to turn off tests for the Appveyor build due to the problems >> >>> with PR#1572. I don't think they are real - do you remember a similiar >> >>> issue with a PR of David Koes, where I had exactly the same problem >> >>> (except here it's multiple tests)? Something's funny with the VMs that >> >>> Appveyor use. If it's real, obviously we'll have to sort it out, but >> >>> the tests pass for me. The main reason for the windows build is simply >> >>> for compilation, so while not ideal, I don't think it's a major issue. >> >>> >> >>> - Noel >> >>> >> >>> >> >>> >> >>> ------------------------------------------------------------------------------ >> >>> Check out the vibrant tech community on one of the world's most >> >>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> >>> _______________________________________________ >> >>> OpenBabel-Devel mailing list >> >>> OpenBabel-Devel@lists.sourceforge.net >> >>> https://lists.sourceforge.net/lists/listinfo/openbabel-devel >> >> >> >> > > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ OpenBabel-Devel mailing list OpenBabel-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-devel
