On Apr 15, 2010, at 5:04 PM, Christian Meisenbichler wrote:
> I hope this is useful. For me it does all I need. Tell me what you think!
Some comments purely regarding the Python side of things.
If you made it a WSGI interface it would run on more systems, and I think be a
bit simpler to write. You can support basic WSGI using the Python standard
library.
Instead of
url=urlparse(self.path)
params = dict([part.split('=') for part in url[4].split('&')])
you can use
url=urlparse.urlparse(self.path)
params = dict(urlparse.parse_psl(url.query)
Did you really mean a 301 response?
self.send_response(301)
> 10.3.2 301 Moved Permanently
>
> The requested resource has been assigned a new permanent URI and any future
> references to this resource SHOULD use one of the returned URIs. Clients with
> link editing capabilities ought to automatically re-link references to the
> Request-URI to one or more of the new references returned by the server,
> where possible. This response is cacheable unless indicated otherwise.
>
> The new permanent URI SHOULD be given by the Location field in the response.
> Unless the request method was HEAD, the entity of the response SHOULD contain
> a short hypertext note with a hyperlink to the new URI(s).
Perhaps you meant a 303?
http://en.wikipedia.org/wiki/Post/Redirect/Get
but in any case, there's no location so it doesn't seem that useful. What not a
regular 200?
Cheers from the self-appointed code reviewer :)
Andrew
da...@dalkescientific.com
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
OpenBabel-discuss mailing list
OpenBabel-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-discuss
