Hi, I haven't looked at the patch in detail, nor do I have any say in the OpenBabel steering, nor any idea of the OpenBabel code philosophy, so this is just my 2c:
On Mon, 2012-02-20 at 20:53 +0100, Paolo Tosco wrote: ... > Once, "false" meant add all hydrogens, and "true" meant add only polar > hydrogens. > Now, 0 means add all hydrogens, 1 means add only polar hydrogens, and -1 > means add only nonpolar hydrogens. Is it possible to add enums/constants or #defines for these magic values, keeping the backward compatibility that you intended ? That could make the code more readable. Yours, Steffen -- IPB Halle AG Massenspektrometrie & Bioinformatik Dr. Steffen Neumann http://www.IPB-Halle.DE Weinberg 3 http://msbi.bic-gh.de 06120 Halle Tel. +49 (0) 345 5582 - 1470 +49 (0) 345 5582 - 0 sneumann(at)IPB-Halle.DE Fax. +49 (0) 345 5582 - 1409 ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ OpenBabel-discuss mailing list OpenBabel-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-discuss
