Thanks Stephen! Was just settling in to take a look at this issue this afternoon.
On Sun, Jul 3, 2011 at 3:02 PM, Stephen Moretti <[email protected]>wrote: > However, both the nightly and SVN have a problem with getPassword() in > adminapi/base.cfc. The return type is set to void when it should be string. > The function is returning a string, but doesn't blow up when the return > function is used, simply ignored and an empty value provided at the calling > end. Is this expected behavior when return is used in a function with void > return type?? That's a nice find and a good question. (Not sure why that's set to returntype="void" in the first place but that's another story.) Personally I would think that if the returntype is void, and the function contains cfreturn, it should throw an error. Alan and Andy will have to chime in, and I don't know what the behavior is in ACF off the top of my head, but it makes logical sense to me that if you declare returntype="void" and the function returns something, or even contains a cfreturn tag or return statement, an error should be thrown. That way you don't have unexpected behavior due to the fact that it's returning an empty string, which is what we're seeing here. > > Repairing getPassword() also seems to fix the error reported by Mat > Stromberg > http://groups.google.com/group/openbd/browse_thread/thread/afe5887f95f3ac71?hl=en > Thanks so much Stephen--I'm testing on my end and if it works I'll commit the changes back to the admin console project. Really appreciate you taking a look at this. Matt -- Matthew Woodward [email protected] http://blog.mattwoodward.com identi.ca / Twitter: @mpwoodward Please do not send me proprietary file formats such as Word, PowerPoint, etc. as attachments. http://www.gnu.org/philosophy/no-word-attachments.html -- official tag/function reference: http://openbd.org/manual/ mailing list - http://groups.google.com/group/openbd?hl=en
