up-2.50topi-pgsql - Build # 74 - Failure:
Check console output at https://ci.openbravo.com/job/up-2.50topi-pgsql/74/ to
view the results.
Committers since last success:
Changes for Build #74
Eduardo Argal Guibert <[email protected]> null
Related to issue 28668: Pressing Cancel in Match Statement or in Process
Reconciliation does not trigger a refresh.
Refactor query to use named parameters to avoid this piece to be used as
template for other developers as this could be a risky practice due to
injections.
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadGetPreferenceActionHandler.java
Eduardo Argal Guibert <[email protected]> null
Related to issue 29353: Refactor of class in FIN_Utility so it can be used
in core. This is now used in Initial Client Setup
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ExecutePayments.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
src/org/openbravo/erpCommon/businessUtility/InitialClientSetup.java
src/org/openbravo/erpCommon/utility/Utility.java
Víctor Martínez Romanos <[email protected]> null
Fixed bug 29353: ICS implemented indirect dataset dependencies
When getting the module dependencies we take into account all the modules
installed in the instance instead of only the one selected by the user.
We use the UpdateReferenceDataData.selectModules() method, which is used by the
Enterprise Module Management process too, to get the right order.
The UpdateReferenceDataData class is now public to be called from
InitialClientSetup.java.
Added missed ProcessingDataset message
src-db/database/sourcedata/AD_MESSAGE.xml
src/org/openbravo/erpCommon/ad_forms/UpdateReferenceData_data.xsql
src/org/openbravo/erpCommon/businessUtility/InitialClientSetup.java
Alvaro Ferraz <[email protected]> null
Related to issue 29720: Modify TestCosting tests
Modify GM11, GM12, GM13 and GM5 tests, where cost adjustments from goods
movements are created, to update accounting amounts
src-test/src/org/openbravo/test/costing/TestCosting.java
Alvaro Ferraz <[email protected]> null
Fixes issue 29720: Wrong accounting in Cost Adjusment
Wrong accounting of the cost adjusment lines in case of Goods Movement From.
In this case, accounting should consider negative amounts, in order to have a
net effect of the goods movement adjustment accounting as 0.
src/org/openbravo/erpCommon/ad_forms/DocCostAdjustment.java
Víctor Martínez Romanos <[email protected]> null
Fixed bug 28592: Added alerts and callout to manage Tax Location
Implemented 2 alerts:
+ Business Partner with no Tax Location Address
+ Business Partner with several Tax Location Addresses
Implemented callout over Location and Tax Location fields (Business Partner |
Location/Address tab) that raises a warning if any of these conditions is
fulfilled for the business partner:
+ More than 1 country set as Tax Location
+ Other country is declared as Tax Location and the user is trying to set a new
country as Tax Location
+ The business partner has several countries and neither of them is declared as
Tax Location
referencedata/standard/Business_Partner_Tax_Location_Alert.xml
src/org/openbravo/erpCommon/ad_callouts/SL_BPartnerLocation.java
src-db/database/sourcedata/AD_CALLOUT.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_DATASET.xml
src-db/database/sourcedata/AD_DATASET_TABLE.xml
src-db/database/sourcedata/AD_MESSAGE.xml
src-db/database/sourcedata/AD_MODEL_OBJECT.xml
src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
Eduardo Argal Guibert <[email protected]> null
Fixes issue 28668: Pressing Cancel in Match Statement or in Process
Reconciliation does not trigger a refresh.
Cancel button has been removed as it was considered confusing. Now there are
two buttons, one for closing the window called 'OK', as it was before, and
another one called 'Reconcile'.
Both triggers refresh. Messages have been added to improve user understanding
on how the window works. New message to inform the user any change will be
persisted. This message can be disabled once clear and will not popup again.
Message to run algorithm as well improved.
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadGetPreferenceActionHandler.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadPreferenceActionHandler.java
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REFERENCE.xml
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REF_LIST.xml
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementActionHandler.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/UnMatchTransactionActionHandler.java
modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
David Baz Fayos <[email protected]> null
Related to issue 29687: Added QUnit test cases - Fixed JSLint problem
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/test/ob-utilities-date-test.js
Unai Martirena <[email protected]> null
Related to bug 28927: Fix unmatching error
An error was being raised while doing unmatch when using
'addSelectedIDsToCriteria' method. The call to this method has been removed
because it is not necessary as the criteria already has the selected ids.
modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
Asier Lostalé <[email protected]> null
related to issue 29719: fixed property store test
CCU property is expected to be present
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/test/ob-property-store-test.js
David Baz Fayos <[email protected]> null
Related to issue 29687: Added QUnit test cases
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/test/ob-utilities-date-test.js
Jorge Garcia <[email protected]> null
Fixed issue 28513: Error message wrongly shown when processing an inventory.
The error message when processing an inventory is wrongly shown with a product
with % in its name and a negative stock.
The issue occurs when we are parsing the error message and detects the % symbol
and try to find the string format in the next character.
The proposal solution is to eliminate the String.format() method from the
code.
Now, the error message is shown properly with the correct name.
src/org/openbravo/materialmgmt/InventoryCountProcess.java
Atul Gaware <[email protected]> null
Fixes Issue 28895:Cannot process an invoice if the role does not have access
to FIN_Payment and the business partner has credit left
Changed OBContext to Admin mode when accessing Description field of Payment
and lastly restored it back again.
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
Alvaro Ferraz <[email protected]> null
Fixes issue 29338: Payment navigation from Transaction tab is working wrong
Issotrx auxiliary input query in Transaction tab has been changed to get into
account related payment isreceipt field, when navigating from it to Payment
In/Out window
Also, SE_Payment_Transaction and SE_Trxtype_Transaction callouts have been
changed to overwrite issotrx session value when updating payment or
transactiontype fields
src-db/database/sourcedata/AD_AUXILIARINPUT.xml
src/org/openbravo/erpCommon/ad_callouts/SE_Payment_Transaction.java
src/org/openbravo/erpCommon/ad_callouts/SE_Trxtype_Transaction.java
Unai Martirena <[email protected]> null
Related to bug 29091: Code Review
[1]: Fix copyright
[2]: Change != for <>
src-db/database/model/functions/A_AMORTIZATION_PROCESS.xml
Jorge Garcia <[email protected]> null
Fixed issue 29091: Fully depreciated field is not updated
The process didn't update the Fully Depreciated field when one or more
asset amortization lines were unprocessed.
The problem was in the amortization process.
Now the process changes the isFullyDepreciated field if the Depreciated
Value and the Depreciated Plan fields are differents.
src-db/database/model/functions/A_AMORTIZATION_PROCESS.xml
Carlos Aristu <[email protected]> null
fixes issue 29667: NPE Error when a child tab is based on an HQL Query table
The NPE was raised because the code was retrieving the entity for a table not
based on a db table. This kind of tables do not have BaseOBObjects.
The FIC was already controlling this when the tab has a related table of this
type but it was not considering the case when the parent table is related to a
table of this type.
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
Carlos Aristu <[email protected]> null
fixes issue 29665: NP Error raised when using HQL Based Tables on a level 2
tab
A unnecessary request was being done when accessing to the HQL query based
subtab. This was caused because the tab was not being identified properly as a
subtab.
The view.parentProperty was used to identify if we are on a child tab. This
property could be undefined depending on the configuration of the tab in the
application dictionary.
Now view.parentView is used instead of view.parentProperty because it does not
return undefined in this cases
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
Asier Lostalé <[email protected]> null
related to issue 29719: fixed jsLint
- Do not use global functions exposed by QUnit but use the ones defined within
the QUnit global object
- Define QUnit as /*global*/ directive JSLint not to complain about it use
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/test/ob-navbar-test.js
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/test/ob-property-store-test.js
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/test/ob-ui-test.js
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/test/ob-utilities-date-test.js
modules/org.openbravo.client.kernel/web/org.openbravo.client.kernel/ui-test-suite/index.html
modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/test/ob-myopenbravo-test.js
Asier Lostalé <[email protected]> null
fixed issue 29270: prevent table recreation in update.database
When adding or removing columns to existing tables update.database does not
recreate the table but just appends the new columns. In order to do this,
column phyisical position wihtin the table is no longer important, being
relative
only to the time they were created but not to the module they belong to.
Asier Lostalé <[email protected]> null
[recreation] prevent table recreation
src-db/database/lib/dbsourcemanager.jar
Asier Lostalé <[email protected]> null
[recreation] added parameter to update.database to force recreation i
All/specific tables can be forced to be recreated when database is updated in
case they have model changes.
src-db/database/build.xml
Asier Lostalé <[email protected]> null
fixed issue 29719: Recover QUnit JavaSript test cases
QUnit test cases are now ready to be included in CI:
-QUnit library has been updated to latest version (1.1.18)
-JavaScript files are loaded in a proper order to guarantee dependencies
-Test cases create an Openbravo session not requiring to use a 2nd tab
-Results are kept in a js object so Selenium can easily access
Asier Lostalé <[email protected]> null
[jsTest] reorganize OBTest object to be easier managed by Selenium
modules/org.openbravo.client.kernel/web/org.openbravo.client.kernel/ui-test-suite/index.html
Asier Lostalé <[email protected]> null
[jsTest] fixed test cases
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/test/ob-navbar-test.js
modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/test/ob-myopenbravo-test.js
Asier Lostalé <[email protected]> null
[jsTest] fixed test case
modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/test/ob-myopenbravo-test.js
Asier Lostalé <[email protected]> null
[jsTest] proper js load and execution, create session before StaticResources
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/TestComponent.java
modules/org.openbravo.client.kernel/web/org.openbravo.client.kernel/ui-test-suite/index.html
Asier Lostalé <[email protected]> null
[jsTest] adapted tests to new QUnit version
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/test/ob-navbar-test.js
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/test/ob-property-store-test.js
Asier Lostalé <[email protected]> null
[jsTest] Updated QUnit to 1.18.0
modules/org.openbravo.client.kernel/web/org.openbravo.client.kernel/ui-test-suite/qunit/qunit.css
modules/org.openbravo.client.kernel/web/org.openbravo.client.kernel/ui-test-suite/qunit/qunit.js
David Baz Fayos <[email protected]> null
Fixed issue 29687: DateTime now works ok with 12:XX:XX times
The root of the problem was that there was a 'typo' and the
'minus' sign was missing in the 'if' statement in charge
of evaluate if it was in 24h mode or not. This was used later
to substract 12h to the entered date if this was in the
12:XX:XX form, change that obviously doesn't apply in the
24h mode
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities-date.js
Inigo Sanchez <[email protected]> null
Fixes bug 28934:Error when launching "Create AP Expense Invoices".
The problem wasn't related with "Openbravo External Connection Pools module".
This issue
has been reproduced without using "Apache JDBC Connection Pool", this is the
error log:
Apr 27, 2015 12:51:47 PM org.apache.catalina.core.StandardWrapperValve invoke
SEVERE: Servlet.service() for servlet P801268 threw exception
org.hibernate.TransactionException: JDBC commit failed
at
org.hibernate.transaction.JDBCTransaction.commit(JDBCTransaction.java:157)
at
org.openbravo.dal.core.SessionHandler.commitAndClose(SessionHandler.java:258)
.........................
at
org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
at java.lang.Thread.run(Thread.java:701)
Caused by: org.postgresql.util.PSQLException: Cannot commit when autoCommit is
enabled.
at
org.postgresql.jdbc2.AbstractJdbc2Connection.commit(AbstractJdbc2Connection.java:705)
at
org.hibernate.transaction.JDBCTransaction.commitAndResetAutoCommit(JDBCTransaction.java:166)
at
org.hibernate.transaction.JDBCTransaction.commit(JDBCTransaction.java:142)
In both cases (default connection pool or apache jdbc connection pool) there
was an error
related with the way of manage connections in "Create AP Expense Invoices"
process.
This connection is obtained with getConnection() method and finally it is
closed in
realeaseCommitConnection() method. This method gets the connection from the
session.
In following uses of "getConnection()" there is an error because this process
closed
the connection of the session.
To fix this, using "getTransactionConnection()" instead of "getConnection()"
method. This method
creates a new connection instead of using the connection of the session. For
this reason, it can
be closed without any problem.
src/org/openbravo/erpCommon/ad_process/ExpenseAPInvoice.java
Eduardo Argal Guibert <[email protected]> null
Fixes Issue 29680:Add details pop up in Payment Out window filters records
with supplier reference
having clause fixed to take into account supplier reference
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/hqlinjections/AddPaymentOrderInvoicesTransformer.java
Jorge Garcia <[email protected]> null
Fixed issue 29697: Description field is set with "null" in the FA
Transaction
Description field is filled in with "null" in the FA Transaction when matched
to GL Item.
The problem was in the Match Statement process, more specifically, in the
Add new transaction button. The AddTransanctionActionHandler didn't
take in consideration that the received description could be null.
The fix for this issue is to check if the received description is null
or blank.
Now, the description field fill in the correct description.
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddTransactionActionHandler.java
Reinaldo Guerra <[email protected]> null
Fixed bug 28702: Assets Organization should not be changed if it has lines
Like happens in other windows such as Products and Business Partner, the
organization's field behaviour in Assets window was changed to not be updatable.
Now when the Assets record is saved, it is not possible to change its
organization, so there will not be inconsistencies with previous created lines
if the amortizations are recalculated.
src-db/database/sourcedata/AD_COLUMN.xml
Unai Martirena <[email protected]> null
Fixed bug 28927: Filter is removed when cancel transactions from Match
process
Changed OB.APRM.MatchStatement.onRefresh function in a similar way to
OB.APRM.AddPayment.currencyOnChange function.
The previous criteria is kept (including the selected record) and used again to
refresh the grid records and redraw the form.
modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
Alvaro Ferraz <[email protected]> null
Fixes issue 29616: Error in GLJournalAccountingCheck validation
Query in GLJournalAccountingCheck build validation has been changed to avoid
build validation fail, when exists a negative gl journal line and system is
configured to "not allow negative amount" during posting, although accounting
information is correct
src-util/buildvalidation/src/org/openbravo/buildvalidation/GLJournalAccountingCheck_data.xsql
Eduardo Argal Guibert <[email protected]> null
Fixes issue 27951
Record is automatically deleted from "General Ledgers" tab when "Organization"
record is updated
Now eventhandler just attends changes in general ledger info
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/GeneralLedgerOrganizationHandler.java
Víctor Martínez Romanos <[email protected]> null
Related to issue 29119: Search for conversion rate when different currencies
The code in charge of getting the conversion rate will be executed only for
different currencies
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
Víctor Martínez Romanos <[email protected]> null
Related to issue 29119: Applied OB code format
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
Reinaldo Guerra <[email protected]> null
Fixed bug 29119: "Use credit" process should consider defined conversion
rate.
The currencies conversion rate, defined for payment's date, is now taken into
account when the credit left by the payment, is used during the invoice's
process.
Now the field exange rate, is well defined in the new payment created, if
exists a conversion between the currencies of the invoice's and the payment's
financial account, for the payment's date.
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
Unai Martirena <[email protected]> null
Fixed bug 28503: Not BOM included in another BOM, is not automatically
exploded.
Stored procedure called M_EXPLODEBOMNOTSTOCK, was changed to make a recursive
call to itself, while a new order line is created with BOM and not stocked
products.
Now a not stocked BOM product included in another not stocked BOM product, is
automatically exploded, when booking order lines.
This change also affects the explode direct process called from Explode button
in order lines tab.
src-db/database/model/functions/M_EXPLODEBOMNOTSTOCK.xml
Jorge Garcia <[email protected]> null
Fixed issue 29226: Value stock report is slow with many rows on
m_transaction
The value stock reports is slow with many rows on the m_transaction_cost table
and most of the them are for the same locator.
The problem was in the sql query from the report. This query needed an
improvement.
The sql query from ReportValuationStockData has changed and now the report is
faster and the return values are the same as before.
src/org/openbravo/erpCommon/ad_reports/ReportValuationStock_data.xsql
Reinaldo Guerra <[email protected]> null
Fixed bug 28685: Goods shipment and invoice relationship not seted in some
cases
Goods shipment and invoice relationship was not created when creating shipments
using manual form: "Create shipments from orders", so like happens when
shipment's lines are created from an specific order, now the invoice's line
related to the order, is updated with the shipment's line when it is created
from the mentioned manual form, only if this field is null in the invoice's
table, i.e. if the invoice is not linked to a previos shipment.
Now goods shipment and invoice relationship is created successfuly when
launching "Create shipments from orders" form.
M_InOut_Create was modified so all processes that executed this stored
procedure are affected with this change.
src-db/database/model/functions/M_INOUT_CREATE.xml
Reinaldo Guerra <[email protected]> null
Fixed bug 28884: Available Credit does not appear from Match Statement
process.
Some request parameters of the JSON context, changes when the Add Paymet
window/process is executed from Match Statement process, so these parameters
are also taken into account now, to obtain the correct display logic boolean
value, for the section "Credit to Use".
Now it is shown the section "Credit to Use", from Match Statement process,
having an Available Credit.
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/TransactionAddPaymentDisplayLogics.java
Last 20 lines of the console output:
[...truncated 197986 lines...]
reverting src-db/database/model/tables/AD_PROCESS_RUN.xml
reverting src-db/database/model/tables/AD_TREE.xml
reverting src-db/database/model/tables/AD_USER.xml
reverting src-db/database/model/tables/C_ACCTSCHEMA_DEFAULT.xml
reverting src-db/database/model/tables/C_BP_BANKACCOUNT.xml
reverting src-db/database/model/tables/FACT_ACCT.xml
reverting src-db/database/model/tables/FIN_FINANCIAL_ACCOUNT.xml
reverting src-db/database/model/tables/FIN_MATCHING_ALGORITHM.xml
reverting src-db/database/model/tables/MA_SEQUENCE_EMPLOYEE.xml
reverting src-db/database/model/tables/MA_SEQUENCE_IC.xml
reverting src-db/database/model/tables/MA_SEQUENCE_MACHINE.xml
reverting src-db/database/sourcedata/AD_FIELD.xml
+ exit 1
Build step 'Execute shell' marked build as failure
Checking console output
/srv/ci/jobs/up-2.50topi-pgsql/builds/2015-05-03_00-00-32/log:
[java] 70789 WARN - SQL Command failed with: ERROR: constraint
"ad_createfact_template_ad_tabl" of relation "ad_createfact_template" does not
exist
Email was triggered for: Failure
Sending email for trigger: Failure
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds
