Unexpected behavior change. We need to run api-check fixed with version java6, until we raise min version of java to java7.
We will change + fix that during today. On Thu, May 7, 2015 at 9:59 AM, <[email protected]> wrote: > int-api - Build # 1379 - Still Failing: > > Check console output at https://ci.openbravo.com/job/int-api/1379/ to view > the results. > > > Committers since last success: > > Changes for Build #1378 > > RM packaging bot <[email protected]> null > Merge back from main > > RM packaging bot <[email protected]> null > Merge temporary head for 3.0PR15Q2 > > RM packaging bot <[email protected]> null > Added signature for changeset ac761ac78f57 > .hgsigs > > RM packaging bot <[email protected]> null > Added tag 3.0PR15Q2 for changeset 4239774eb8de > .hgtags > > RM packaging bot <[email protected]> null > Update AD_MODULE version to 3.0PR15Q2 > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > src-db/database/sourcedata/AD_MODULE.xml > > Jorge Garcia <[email protected]> null > Fixed issue 29777: Header of warehouse picking module do not refresh > > Header of warehouse picking module do not refresh in some circunstances. > > Issue of platform. > > The problem was that the toolbar didn't update when the Manage Incidences > process finished. > > The solution is to update the toolbar when the ActionHandler return the > responded JSON. > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js > > Inigo Sanchez <[email protected]> null > Fixed bug 29759:Problems with inherited permissions in process definition > > The problem was that when a process containing parameters defined as "window" > is launched , this manual role has > not access to windows contained in that process definition. > > The cause of this issue is that before 14Q3, no security check was done on > P&E grids, so data always was retrieved. > >From 15Q1, security is checked requiring explicit access to P&E grid. > > The issue is fixed by inheriting access from the process, this is if the > process is accessible the grid within the > P&E doesn't require to have explicit access but inherits from the process > itself. > > modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java > > modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java > > Alvaro Ferraz <[email protected]> null > Related to issue 29735: Modify TestCosting tests > > Modify GM11, GM12, GM13 and GM5 tests, where cost adjustments from goods > movements are created, to update accounting amounts > src-test/src/org/openbravo/test/costing/TestCosting.java > > Alvaro Ferraz <[email protected]> null > Fixes issue 29735: Wrong accounting in Cost Adjusment > > Wrong accounting of the cost adjusment lines in case of Goods Movement From. > In this case, accounting should consider negative amounts, in order to have a > net effect of the goods movement adjustment accounting as 0. > src/org/openbravo/erpCommon/ad_forms/DocCostAdjustment.java > > Eduardo Argal Guibert <[email protected]> null > Fixes issue 29726: Pressing Cancel in Match Statement or in Process > Reconciliation does not trigger a refresh. > Cancel button has been removed as it was considered confusing. Now there are > two buttons, one for closing the window called 'OK', as it was before, and > another one called 'Reconcile'. > > Both triggers refresh. Messages have been added to improve user understanding > on how the window works. New message to inform the user any change will be > persisted. This message can be disabled once clear and will not popup again. > Message to run algorithm as well improved. > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadGetPreferenceActionHandler.java > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadPreferenceActionHandler.java > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REFERENCE.xml > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REF_LIST.xml > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementActionHandler.java > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js > > Alvaro Ferraz <[email protected]> null > Fixes issue 29721: Payment navigation from Transaction tab is working > wrong > > Issotrx auxiliary input query in Transaction tab has been changed to get into > account related payment isreceipt field, when navigating from it to Payment > In/Out window > Also, SE_Payment_Transaction and SE_Trxtype_Transaction callouts have been > changed to overwrite issotrx session value when updating payment or > transactiontype fields > src-db/database/sourcedata/AD_AUXILIARINPUT.xml > src/org/openbravo/erpCommon/ad_callouts/SE_Payment_Transaction.java > src/org/openbravo/erpCommon/ad_callouts/SE_Trxtype_Transaction.java > > David Baz Fayos <[email protected]> null > Fixed issue 29691: DateTime now works ok with 12:XX:XX times > > The root of the problem was that there was a 'typo' and the > 'minus' sign was missing in the 'if' statement in charge > of evaluate if it was in 24h mode or not. This was used later > to substract 12h to the entered date if this was in the > 12:XX:XX form, change that obviously doesn't apply in the > 24h mode > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities-date.js > > Jorge Garcia <[email protected]> null > Fixed issue 29704: Description field is set with "null" in the FA > Transaction > > Description field is filled in with "null" in the FA Transaction when matched > to GL Item. > > The problem was in the Match Statement process, more specifically, in the > Add new transaction button. The AddTransanctionActionHandler didn't > take in consideration that the received description could be null. > > The fix for this issue is to check if the received description is null > or blank. > > Now, the description field fill in the correct description. > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddTransactionActionHandler.java > > Unai Martirena <[email protected]> null > Fixes bug 29677: Fix NPE in Costing Background with Standard Costing Rule > > In Cost Adjustment project new method has been added to calculate an opening > inventory cost. This method uses 'CostinUtils.getStandardCostDefinition' > method, that tries to get an standard cost for that opening inventory. If it > does not found any standard or legacy cost, it returns null. So, in this > moment a NPE error was happening. To fix this problem, at this point a > controlled error is raised to notify the user that no cost has been found. > src/org/openbravo/costing/StandardAlgorithm.java > > Víctor Martínez Romanos <[email protected]> null > Related to issue 29644: changed column in selector field > to get the right name, description and help for the selector's column > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml > > Alvaro Ferraz <[email protected]> null > Fixes issue 29644: BP selector in AddTransaction shows all bp > > "Business Partner selector" selector of "Business Partner" paramenter in > "AddTransaction" process definition, has been changed into "Business Partner > selector without default expressions" selector; in order to show all business > partners in the dropdown of the selector. > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REFERENCE.xml > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUISEL_SELECTOR.xml > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml > > Alvaro Ferraz <[email protected]> null > Fixes issue 29659: GLItem lost in Add new Transaction window > > Neither payment nor glitem will be deleted when changing to Bank fee in Add > new Transaction window. Instead, when clicking on Done and creating the > transaction, AddTransactionActionHandler will check if the transaction is of > type Bank fee and in this case it will set as null both fields. > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddTransactionActionHandler.java > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js > > Víctor Martínez Romanos <[email protected]> null > Fixed bug 29654: Payment selector now filters by child organizations > > The payment selector was incorrectly filtering by child organizations because > the order of the parameters in the call to the AD_ISORGINCLUDED function was > wrong. > > It now gets all the payments belonging to the organization and any child > organization of the tab's organization. > src-db/database/sourcedata/OBUISEL_SELECTOR.xml > > Alvaro Ferraz <[email protected]> null > Fixes issue 29633: Foreign currency not setted in transaction > > When creating a transaction manually from a payment, foreign currency, > foreign conversion rate and foreign amount fields were not setted to > transaction. Now, they will be setted as in TransactionDao.java, when the > transaction is automatically created from the payment. > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java > > Unai Martirena <[email protected]> null > Fixes bug 29619: Correctly used credit when paying an invoice and > refunding > > There were two issues while managing this scenario: > > [1] In 'addCredit' method inside AddPaymentActionHandler.java class, a loop > of Credit to Use grid is done, creating Payment Credit Used records assigned > to the new created payment of the invoice. This method was not taking into > account that could be credit amount that exceeds the invoice amount (amount > to be refunded) and it was assigning all the credit amount as used to the > payment of the invoice. So the refund payment that is created right after was > been left without any used credit payment. > > [2] After fixing the previous method, the second issue appears. The > 'updateUsedCredit' method inside FIN_PaymentProcess.java class retrieves all > the payments of the business partner that has generated credit, and it > assigns as used to the refund payment. The problem with this function is that > before the Add Payment refactor it was not possible to select which credit > payments we wanted to consume, it was only a total credit amount to be > consumed and the system behind was being consuming any of them. But after the > refactor it is possible to select the ones that want to be consumed. > > In order to fix this last issue the selected credit line ids are added as a > parameter to 'updateUsedCredit' method. > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java > > Inigo Sanchez <[email protected]> null > Fixed bug 29628: setup application is not taking into account the context > name > > The setup application is not taking into account the context name that users > are configuring. The values of "deploy-name" and "context-root" properties > of org.eclipse.wst.common.component are not updating. > > Now it has been solved and if user set "context-name" in setup application. > this value is updating in org.eclipse.wst.common.component. For example if > a user set the context name as "test" the URL to go to Openbravo is > "http://localhost:8080/test"; instead of default one > "http://localhost:8080/openbravo";. > src/org/openbravo/configuration/ConfigurationApp.java > > Alvaro Ferraz <[email protected]> null > Fixes issue 29616: Error in GLJournalAccountingCheck validation > > Query in GLJournalAccountingCheck build validation has been changed to avoid > build validation fail, when exists a negative gl journal line and system is > configured to "not allow negative amount" during posting, although accounting > information is correct > > src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/GLJournalAccountingCheckData.class > > src-util/buildvalidation/src/org/openbravo/buildvalidation/GLJournalAccountingCheck_data.xsql > > Asier Lostalé <[email protected]> null > fixed bug 29609: System cannot be rebuilt having Tomcat JDBC Pool > > OBPropertiesProvider.setProperties method was invoked when rebuilding > to get a connection, as this method tried to log with INFO level, it caused > recursive invokations. > > Messages logged while setting properties have been lowered to DEBUG to > prevent > this situation. > src/org/openbravo/base/session/OBPropertiesProvider.java > > Unai Martirena <[email protected]> null > Fixes bug 29545: Accounting Date is updated when Transaction Date changes > > A callout has been added in Transaction Date field of transaction tab under > Financial Account. > > An onchange function has been added in Transaction Date in Add Transaction > Process Definition. > > src/org/openbravo/erpCommon/ad_callouts/SE_StatementDate_Transaction.java > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js > src-db/database/sourcedata/AD_CALLOUT.xml > src-db/database/sourcedata/AD_COLUMN.xml > src-db/database/sourcedata/AD_MODEL_OBJECT.xml > src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml > > Jorge Garcia <[email protected]> null > Fixed issue 29584: It is not possible to reactivate a Landed Cost > > It is not possible to reactivate a Landed Cost under some circunstances. > The problem was fixed from the LandedCostDistributionAlgorithm.java > > When you try to reactivate a Landed Cost, an error message appears and > the process was cancelled > > Now the process is done succesfully and the Landed Cost can be reactivated. > src/org/openbravo/costing/LandedCostDistributionAlgorithm.java > > Carlos Aristu <[email protected]> null > fixes issue 29567: onChange event does not work fine > using Date parameters in Process Definition > > There were two different problems: > 1) When changing the value manually, the _textChanged attribute was always > true after the first change. This prevented the date value to be updated > properly. This has been solved by creating a new method, > setDateParameterValue, which avoids this problem when setting the date > parameter values. The following documentation has been updated with this > information: > http://wiki.openbravo.com/wiki/How_to_create_a_Standard_Process_Definition#Advanced_Topics > 2) When changing the value from the date picker, the onblur event was not > being called after the first time. This has been solved by calling the > handleItemChange method of the OBParameterWindowForm class after choosing the > value from the picker. > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-date.js > > Unai Martirena <[email protected]> null > Fixes issue 29510: Duplicated amount when cancelled payment > > Removes canceled payment schedule details when posting. > src/org/openbravo/erpCommon/ad_forms/DocInvoice_data.xsql > > Alvaro Ferraz <[email protected]> null > Related to issue 29541: Removed unused parameter > > Removed unused parameter in getConversionRateDocumentForInvoice method > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java > > Unai Martirena <[email protected]> null > Fixes bug 29541: Payment Out can be reactivated without bp purchase > pricelist > > The problem is that the method 'getConversionRateDocumentForInvoice' tries to > get a conversion using the currency of Purchase PriceList of the business > partner, and it could happen to be empty, so it fails. > > Starting from 3.0PR14Q4 the Currency field in the business partner is > mandatory, so it can be used for Sales/Purchase flow. > > It could be that at this point while reactivating the Payment to be the > Currency of the Business Partner null, because it was created long time ago > and no currency set yet, so, if this is the case an error will be raised to > the user in order to fix this. > > A last change has been made in 'OBMessageUtils.messageBD' method, adding an > extra parameter when it is wanted to avoid doing escape of '\n' and > doublequotes characters. In this case it is needed because the message that > needs to be displayed needs to maintain them because contains a link. This > implementation is similar to the one found in BasicUtility.messageBD. > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java > src/org/openbravo/erpCommon/utility/OBMessageUtils.java > > Unai Martirena <[email protected]> null > Fixes bug 29474: Cannot be reserved more than available Stock. > > Few more issues have been fixed also: > > 1) Prereservation lines will never have Warehouse field filled until they are > received. > > 2) Filter of Purchase Order Line now is working having reservation completed > or in draft status. > > 3) Prereservation Lines are displayed when the reservation is in draft status > and they are not still reserved. > > src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java > > Unai Martirena <[email protected]> null > Fixes bug 29535: Transaction can be created from Add transaction for Bank > Fee > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddTransactionActionHandler.java > > Jorge Garcia <[email protected]> null > Fixed issue 29504: It is possible to create a payment in/out > > It is possible to create a payment header when a payment method or a financial > account is disabled in a given financial account. > > Now only active payment methods of financial accounts and active financial > accounts are showing in the payment in / payment out window. > > In addition, if the user selects a business partner in these windows and the > default payment method and/or the default financial account is/are inactive, > a warning message is shown to the user, indicating which one is inactive. > > These warning messages are also included in the fix. > src-db/database/sourcedata/AD_MESSAGE.xml > src-db/database/sourcedata/AD_VAL_RULE.xml > src/org/openbravo/erpCommon/ad_callouts/SE_Payment_BPartner.java > > Unai Martirena <[email protected]> null > Related to bu 29497: Code Review > > Use ParameterType instead of InputType for CONSTANT String. > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java > > Víctor Martínez Romanos <[email protected]> null > Fixed bug 29497: Several issues in Match Statement > > 1) Wrong management of default parameters in automatic execution process: > ParameterType was used where InputType was expected (and the opposite) > > 2) NPE when working with default parameters in execution process > constantParameters attribute wasn't initialized before being used. Fixed also > parameters attribute with the same potential issue > > 3) Impossible to create a new payment from transaction when the payment > method has an automatic execution process and automatic deposit/withdrawn > We now pass an internal parameter "comingFrom" to know if we come from a > transaction. In this case we don't create automatically the transaction > (regardless the payment method is automatic deposit/withdrawn) to avoid > breaking the unique constraint FIN_FINACC_TRANSACTION_UN inside > FIN_FINACC_TRANSACTION table > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java > > Asier Lostalé <[email protected]> null > fixed bug 29466: list reference are validated while typing > > This caused to see the field in red as non valid while typing to filter a > value. > > It has been fixed in the same way selector reference does: preventing > validation > on filterComplete. A new OBComboBoxItem class has been implemented in order > to > make both list and selectors (including table and tableDir) extend it > preventing > in this manner code duplicities. > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-combo.js > > modules/org.openbravo.client.application/src/org/openbravo/client/application/ApplicationComponentProvider.java > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list.js > > modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js > > Unai Martirena <[email protected]> null > Fixes bug 29472: Bank Statement Line amount maintained in Add Payment > from FA > > If exists bslamount this means that Add Payment window has been opened from > Match Statement window, so, when selecting a line in Order/Invoices grid, > this amount will be set in the line when is smaller than outstanding amount. > > If Outstanding amount is smaller, then outstanding amount will be assigned. > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js > > Alvaro Ferraz <[email protected]> null > Fixes issue 29480: Lines shown when filtering by a wrong value > > Lines will not be shown, if they are not checked, when filtering by a wrong > value in a number type column, in Manage Reservation popup > > src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java > > Unai Martirena <[email protected]> null > Fixes bug 29487: Performance improved in Costing Background process. > > There are two methods in Costing Background process in which an > ScrollableResult is built and iterated. > 'setCalculatedTransactionsAsProcessed' and > 'setCalculatedTransactionsAsProcessed'. This loops where causing Out of > memory issues because they were not flushing and clearing session every > little amount of iterations. Apart from this, the two ScrollableResults were > leaving opened, which may cause lot of issues especially in Oracle. > > Finally, these methods have been implemented in another way. Directly > updating all the records on a single update in hql. In this way the > performance is improved even adding flush and clear on the previously loops. > src/org/openbravo/costing/CostingBackground.java > > Unai Martirena <[email protected]> null > Fixed bug 29471: Invoice's entry Currency Balancing instead of Vendor > Prepayment > > > The selectPrepayments method now searches by > FIN_PAYMENT_SCHEDULEDETAIL.FIN_PAYMENT_SCHEDULE_ORDER instead of > FIN_PAYMENT_SCHEDULEDETAIL.FIN_PAYMENT_SCHEDULE_INVOICE, because a prepayment > is linked to an order. > src/org/openbravo/erpCommon/ad_forms/DocInvoice_data.xsql > > RM packaging bot <[email protected]> null > Merge temporary head for 3.0PR15Q1.3 > > RM packaging bot <[email protected]> null > Added signature for changeset 4d63b001f637 > .hgsigs > > RM packaging bot <[email protected]> null > Added tag 3.0PR15Q1.3 for changeset ad409516bfa0 > .hgtags > > RM packaging bot <[email protected]> null > Update AD_MODULE version to 3.0PR15Q1.3 > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > src-db/database/sourcedata/AD_MODULE.xml > > Alvaro Ferraz <[email protected]> null > Fixes issue 29617: Error in GLJournalAccountingCheck validation > > Query in GLJournalAccountingCheck build validation has been changed to avoid > build validation fail, when exists a negative gl journal line and system is > configured to "not allow negative amount" during posting, although accounting > information is correct > > src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/GLJournalAccountingCheckData.class > > src-util/buildvalidation/src/org/openbravo/buildvalidation/GLJournalAccountingCheck_data.xsql > > Unai Martirena <[email protected]> null > Fixes bug 29546: Accounting Date is updated when Transaction Date changes > > A callout has been added in Transaction Date field of transaction tab under > Financial Account. > > An onchange function has been added in Transaction Date in Add Transaction > Process Definition. > > src/org/openbravo/erpCommon/ad_callouts/SE_StatementDate_Transaction.java > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js > src-db/database/sourcedata/AD_CALLOUT.xml > src-db/database/sourcedata/AD_COLUMN.xml > src-db/database/sourcedata/AD_MODEL_OBJECT.xml > src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml > > Jorge Garcia <[email protected]> null > Fixed issue 29585: It is not possible to reactivate a Landed Cost > > It is not possible to reactivate a Landed Cost under some circunstances. > The problem was fixed from the LandedCostDistributionAlgorithm.java > > When you try to reactivate a Landed Cost, an error message appears and > the process was cancelled > > Now the process is done succesfully and the Landed Cost can be reactivated. > src/org/openbravo/costing/LandedCostDistributionAlgorithm.java > > Carlos Aristu <[email protected]> null > fixes issue 29568: onChange event does not work fine > using Date parameters in Process Definition > > There were two different problems: > 1) When changing the value manually, the _textChanged attribute was always > true after the first change. This prevented the date value to be updated > properly. This has been solved by creating a new method, > setDateParameterValue, which avoids this problem when setting the date > parameter values. The following documentation has been updated with this > information: > http://wiki.openbravo.com/wiki/How_to_create_a_Standard_Process_Definition#Advanced_Topics > 2) When changing the value from the date picker, the onblur event was not > being called after the first time. This has been solved by calling the > handleItemChange method of the OBParameterWindowForm class after choosing the > value from the picker. > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-date.js > > Eduardo Argal Guibert <[email protected]> null > Fixes issue 29511: Duplicated amount when cancelled payment > Removes canceled payment schedule details when posting > src/org/openbravo/erpCommon/ad_forms/DocInvoice_data.xsql > > Eduardo Argal Guibert <[email protected]> null > Fixes bug 29547: Cannot be reserved more than available Stock. > > Few more issues have been fixed also: > > 1) Prereservation lines will never have Warehouse field filled until they are > received. > > 2) Filter of Purchase Order Line now is working having reservation completed > or in draft status. > > 3) Prereservation Lines are displayed when the reservation is in draft status > and they are not still reserved. > > src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java > > Unai Martirena <[email protected]> null > Related to bug 29536: Fix copyright > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddTransactionActionHandler.java > > Eduardo Argal Guibert <[email protected]> null > Fixes bug 29536: Transaction can be created from Add transaction for Bank > Fee > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddTransactionActionHandler.java > > Unai Martirena <[email protected]> null > Fixes bug 29542: Payment Out can be reactivated without bp purchase > pricelist > > The problem is that the method 'getConversionRateDocumentForInvoice' tries to > get a conversion using the currency of Purchase PriceList of the business > partner, and it could happen to be empty, so it fails. > > Starting from 3.0PR14Q4 the Currency field in the business partner is > mandatory, so it can be used for Sales/Purchase flow. > > It could be that at this point while reactivating the Payment to be the > Currency of the Business Partner null, because it was created long time ago > and no currency set yet, so, if this is the case an error will be raised to > the user in order to fix this. > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java > > Unai Martirena <[email protected]> null > Related to bug 29449: Avoid exception when filtering by number > > Avoid exceptions when retrieving the value of the filter in number-type > columns and the value is not a number > > src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java > > Unai Martirena <[email protected]> null > Related to bug 29449: Avoid exception > > Avoid exceptions in getOrderLineSetValueFilterData and > getAttributeSetValueFilterData methods > > src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java > > Unai Martirena <[email protected]> null > Related to issue 29448: Empty filter when there is no attribute set value. > > When records are created in Stock Reservation pick and edit, the 0 value > retrieved from default attribute set instance, defined in reservation's > tables, is now set to null, when creating filter criteria. > Now if there is no attribute set defined for reservation's products, the > attribute set value filter is empty. > > src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java > > Unai Martirena <[email protected]> null > Fixes bug 29448, Fixes bug 29447, Fixes bug 29449 > > The following changes was made in Stock Reservation pick and edit: > When filters are executed, a Reservation entity is created from the json > parameter @MaterialMgmtReservation.id@. This works fine when the pop-up is > called from Stock Reservation window, but from Sales Order, this parameter > does not exists, and the filter process fails. Now is included a code line > that puts a @MaterialMgmtReservation.id@ into the json parameters before the > filters are applied. > Array critera filtering was bad created when getting grid's data, so was > changed, to allow filter's multiple selection. > An hibernate exception is launched when typing wrong filters and the > expression 'in ()' is included in the query to be executed. So this > expression was replaced by one which returns a false value: '1 = 2' > Were included also, changes to allow filtering quantity's column. Other > changes were included to avoid exceptions comparing to null values. > > src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java > > Jorge Garcia <[email protected]> null > Fixed issue 29461: It is possible to create a payment in/out > > It is possible to create a payment header when a payment method or a financial > account is disabled in a given financial account. > > Now only active payment methods of financial accounts and active financial > accounts are showing in the payment in / payment out window. > > In addition, if the user selects a business partner in these windows and the > default payment method and/or the default financial account is/are inactive, > a warning message is shown to the user, indicating which one is inactive. > > These warning messages are also included in the fix. > src-db/database/sourcedata/AD_MESSAGE.xml > src-db/database/sourcedata/AD_VAL_RULE.xml > src/org/openbravo/erpCommon/ad_callouts/SE_Payment_BPartner.java > > Unai Martirena <[email protected]> null > Related to bug 29498: Code review > > Use ParameterType instead of InputType for CONSTANT String. > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java > > Víctor Martínez Romanos <[email protected]> null > Fixed bug 29498: Several issues in Match Statement > > 1) Wrong management of default parameters in automatic execution process: > ParameterType was used where InputType was expected (and the opposite) > > 2) NPE when working with default parameters in execution process > constantParameters attribute wasn't initialized before being used. Fixed also > parameters attribute with the same potential issue > > 3) Impossible to create a new payment from transaction when the payment > method has an automatic execution process and automatic deposit/withdrawn > We now pass an internal parameter "comingFrom" to know if we come from a > transaction. In this case we don't create automatically the transaction > (regardless the payment method is automatic deposit/withdrawn) to avoid > breaking the unique constraint FIN_FINACC_TRANSACTION_UN inside > FIN_FINACC_TRANSACTION table > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java > > Asier Lostalé <[email protected]> null > fixed bug 29467: list reference are validated while typing > > This caused to see the field in red as non valid while typing to filter a > value. > > It has been fixed in the same way selector reference does: preventing > validation > on filterComplete. A new OBComboBoxItem class has been implemented in order > to > make both list and selectors (including table and tableDir) extend it > preventing > in this manner code duplicities. > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-combo.js > > modules/org.openbravo.client.application/src/org/openbravo/client/application/ApplicationComponentProvider.java > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list.js > > modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js > > Asier Lostalé <[email protected]> null > fixed bug 29428: Distinct parameter is not working in JSON REST web > services > > Using _distinct property in JSON REST webservices resulted in an incorrectly > generated query. There were 2 problems: > > - Entity name for was set in the fetch method, after the refactor done to > fix > issue #25182, entity is different in case of using _distinct, and it is > managed > by QueryService. > - This refactor also requires of using aliases to work > > modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java > > modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonRestServlet.java > > Asier Lostalé <[email protected]> null > fixed bug 29453: Process Definition without params popup is not closed > > When a process defintion has no parameters, it is not closed after > execution/failure. > > The problem was due the invokation of allRequiredParametersSet which now is > performed > after validation, this method incorretly assumed there was a form with > paramters. > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js > > Asier Lostalé <[email protected]> null > fixed bug 29416, related to issue 29424: Done can be clicked more than > once > > In process definition Done button was enabled and clickable while client > side > validations were being evaluated. This was specially noticeable if those > validations > perform backend requests to be completed (which is the case of Add Payment). > > Fixed by disabling Done button as first step before executing any > validation. > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-findTransaction.js > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js > web/js/validateCostingRuleProcess.js > > Unai Martirena <[email protected]> null > Fixes bug 29473: Bank Statement Line amount maintained in Add Payment > from FA > > If exists bslamount this means that Add Payment window has been opened from > Match Statement window, so, when selecting a line in Order/Invoices grid, > this amount will be set in the line when is smaller than outstanding amount. > > If Outstanding amount is smaller, then outstanding amount will be assigned. > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js > > Unai Martirena <[email protected]> null > Fixes bug 29454: Initialize dateacct column is always been done. > > At the beginning of costing background a process to initialize dateacct > column of m_transaction_cost has being added. This process is independant > from Costing Background, but it was added here to avoid the performance > problems that it was causing when executing as a modulescript. > > It this columns are not initialized it will not be possible to launch 'Sales > Invoice Dimensional Report' and 'Valued Stock Report'. The problem happens > when the Costing Background process fails for the first transaction that is > calculating, because it rollbacks everything, including the process to > initialize dateacct column, so, it is not possible to launch the two reports. > src/org/openbravo/costing/CostingBackground.java > > Augusto Mauch <[email protected]> null > Fixes bug 29097: A menu tree node can be moved with a template in > development > > When the Openbravo Trees were reimplemented [1], there was a problem > reimplementing the logic done when a Menu tree item is moved. Before the > reimplementation, it was possible to move a menu tree item if the module it > belonged to was in development or if there was any template module in > development. The reimplementation did not take into account the templates, so > from then on it has not been possible to moved menu tree nodes having a > template in development. > > To fix this, templates are taken into accout in the MenuTreeOperationManager > class. > > [1] https://issues.openbravo.com/view.php?id=25906 > > modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/treeChecks/MenuTreeOperationManager.java > > Víctor Martínez Romanos <[email protected]> null > Fixed bug 29456: Invoice's entry Currency Balancing instead of Vendor > Prepayment > > The selectPrepayments method now searches by > FIN_PAYMENT_SCHEDULEDETAIL.FIN_PAYMENT_SCHEDULE_ORDER instead of > FIN_PAYMENT_SCHEDULEDETAIL.FIN_PAYMENT_SCHEDULE_INVOICE, because a prepayment > is linked to an order. > src/org/openbravo/erpCommon/ad_forms/DocInvoice_data.xsql > > Unai Martirena <[email protected]> null > Fixes bug 29188: Performance improved in Costing Background process. > > There are two methods in Costing Background process in which an > ScrollableResult is built and iterated. > 'setCalculatedTransactionsAsProcessed' and > 'setCalculatedTransactionsAsProcessed'. This loops where causing Out of > memory issues because they were not flushing and clearing session every > little amount of iterations. Apart from this, the two ScrollableResults were > leaving opened, which may cause lot of issues especially in Oracle. > > Finally, these methods have been implemented in another way. Directly > updating all the records on a single update in hql. In this way the > performance is improved even adding flush and clear on the previously loops. > src/org/openbravo/costing/CostingBackground.java > > RM packaging bot <[email protected]> null > Merge temporary head for 3.0PR15Q1.2 > > RM packaging bot <[email protected]> null > Added signature for changeset 295e0a259f61 > .hgsigs > > RM packaging bot <[email protected]> null > Added tag 3.0PR15Q1.2 for changeset 31dfe7896f8f > .hgtags > > RM packaging bot <[email protected]> null > Update AD_MODULE version to 3.0PR15Q1.2 > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > > modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE.xml > > modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml > src-db/database/sourcedata/AD_MODULE.xml > > Unai Martirena <[email protected]> null > Fixes bug 29432: Net Unit Price in Costing is properly calculated > > Using Cost Adjustments the Net Unit Price of a product on a transaction could > be affected with those. Starting from now the Net Unit Price assigned in > Costing tab is going to take into account the Cost Adjustments of type Unit > Cost. > > So the calculation would be: ((originalPrice * qty) + adjustmentsAmount) / > qty. > src/org/openbravo/costing/AverageCostAdjustment.java > > Unai Martirena <[email protected]> null > Fixes bug 29423: Round with standard precision cost adjutment amounts > > There are certain places in which the amount to be adjusted was being rounded > to costing precision, instead of standard precision, and this is wrong > because the amounts allways has to be at most of precision 2. > src/org/openbravo/costing/AverageCostAdjustment.java > > Unai Martirena <[email protected]> null > Related to issue 29228: Fix copyright > src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java > > Alvaro Ferraz <[email protected]> null > Fixes issue 29228: G/L Journal Accounting amounts are not setted correctly > > Conversion rate to apply to accounting amounts will be getted from the system > when it is setted as multi-general ledger and from the document when it is not > src/org/openbravo/erpCommon/ad_forms/DocGLJournal.java > > Alvaro Ferraz <[email protected]> null > Related to issue 29228: Add a build validation to create an alert if > wrong data > > A build validation will be executed to check if it exists wrong data (g/l > journal accounting with wrong amounts) related to the issue. In that case an > alert will be created to tell the user to reset accounting, but when fixed it > will be deactivated to avoid execute it again. > The build validation will only be executed when updating from Q1 or Q1.1, > because the issue is introduced in Q1 and resolved in Q1.2. > > src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/GLJournalAccountingCheck.class > > src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/GLJournalAccountingCheckData.class > > src-util/buildvalidation/src/org/openbravo/buildvalidation/GLJournalAccountingCheck.java > > src-util/buildvalidation/src/org/openbravo/buildvalidation/GLJournalAccountingCheck_data.xsql > > Reinaldo Guerra <[email protected]> null > Fixes Issue 29355:You can launch Pending Goods Receipts process with wrong > Locators > > Purchase order header's organization id is used to filter the locators > in the locator selector of Pending Goods Receipt. > src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.html > src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.xml > src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending_data.xsql > > Unai Martirena <[email protected]> null > Fixes bug 29189: LazyInitializationException avoided calculating BOM > prod. cost > > prodLine has been reloaded in case cost calculation of previous BOM Product > has cleared the session. > src/org/openbravo/costing/CostingAlgorithm.java > > Unai Martirena <[email protected]> null > Fixes bug 29190: getStartingDate() method does not fail in Costing > Background. > > An OBQuery is being executed in getStartingDate() method inside > AverageAlgorithm. There are 2 parameters in this OBQuery that are not setting > properly, 'client' and 'org'. The whereclause is filtering by 'id' of these > properties and instead of passing the id of these objects, the object was > being passed to the OBQuery. These sometimes works but other times don't, so > this has been changed to always setting the id's as parameters. > src/org/openbravo/costing/AverageAlgorithm.java > > Unai Martirena <[email protected]> null > Fixes bug 29191: Fixed Costing Background infinite loop. > > Costing Background process, due to Cost Adjustments new implementation, on a > certain point of the code, it was not applying correctly a setScale method to > round a value of the expected cost. This was causing to have allways a > difference between the expected cost and unitcost. Because of this, an > adjustment was being created to adjust this difference, and to adjust all > related transactions, causing an infinite loop > src/org/openbravo/costing/AverageCostAdjustment.java > > Augusto Mauch <[email protected]> null > Fixes bug 29379: Warehouse field of Manage Reservation P&E shows a proper > value > > The is a bug in that P&E, reported here [1], that makes the FIC return the > wrong value for the warehouse field of the Manage Reservation P&E window. > Before [2] was fixed, [1] did not have any consequences, as the value > returned by the FIC was not set to the row being edited. > > To fix this, the values returned by the FIC are only set if the field is > editable. [1] will have to be fixed anyway, because even if now it does not > crete problems in this flow, it could be causing problems in others. > > [1] https://issues.openbravo.com/view.php?id=29381 > [2] https://issues.openbravo.com/view.php?id=28727 > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js > > Alvaro Ferraz <[email protected]> null > Related to issue 29383: Make code more clear > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddTransactionFilterExpression.java > > Alvaro Ferraz <[email protected]> null > Related to issue 29383: Update copyright > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddTransactionFilterExpression.java > > Reinaldo Guerra <[email protected]> null > Fixed bug 29383: Add Transaction process does not consider well amounts > of 0.00 > > The "compareTo" method was taken into account instead of "equals", to compare > BigDecimal.ZERO value with 0.00 (a BigDecimal value with a scale), inside > AddTransactionFilterExpression class. > This change was made because BigDecimal "equals", compares the value and the > scale, returning false when comparing 0 with 0.00, while "compareTo" only > compares values, so considers amounts 0.00 and 0 as the same values. Now > transaction type is correctly set to BP Deposit, when "dramount" field is set > to 0.00. > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddTransactionFilterExpression.java > > Unai Martirena <[email protected]> null > Fixes bug 29192: Fixed wrong costing entries after some circumstancies > > Method 'getTrxCurrentCosting' in AverageCostAdjustment it was filtering by > organization when working with 'production' type products, and this is not > working, it should filter by client in this case, as all costing records for > this type of products are at client level. > src/org/openbravo/costing/AverageCostAdjustment.java > > Alvaro Ferraz <[email protected]> null > Related to issue 29207: Update copyright > > modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml > > Sandra Huguet <[email protected]> null > Fixed bug 29207 Payment Out is registered as "BP Deposit" transaction > > In FIN_TransactionProcess.java set the correct value depending on > the type of transaction > Fix aprm_gen_paymentschedule_inv function in order to have the > same behavior on all automatic processes > > modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java > > Sandra Huguet <[email protected]> null > related to issue 29021, related to issue 29051, related to issue 29052 > > improve the error message > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js > > Sandra Huguet <[email protected]> null > related to 29299 update Copyright > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddPaymentDefaultValuesHandler.java > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/TransactionAddPaymentDefaultValues.java > > Unai Martirena <[email protected]> null > Fixes bug 29299: Payment method in add payment does not display inactive > values > > The whereClause of fin_payment_method combo in add payment has been changed > to not display never payment methods that are inactive. > > Also the default values of Add Payment window that are opened from all > windows has been changed to not set as default a Payment Method that is > inactive, even if it is marked as default in the financial account or if is > the default payment method of the Business Partner. > > A change has also been done in OB.APRM.AddPayment.paymentMethodMulticurrency > javascript function. In Add Payment window, while clearing Payment Method > combo manually, the Financial Account was also being cleared. This was > causing a problem when opening from Financial Account, because in this case > novalues were displayed on both combos any more. It has been fixed to not to > clear the Financial Account combo in this case as always is going to be the > same, so it is no necessary to clear it. > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUISEL_SELECTOR.xml > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddPaymentDefaultValuesHandler.java > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/TransactionAddPaymentDefaultValues.java > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js > > Unai Martirena <[email protected]> null > Fixes bug 29249: Transactions created in Match Statement are created > processed > > On Reconciliation Refactor process and new function was added to process > transactions in APRM_MatchingUtility class, replacing the old > processTransaction in MatchTransaction servlet. In the new method, the way in > which the database stored procedure was being invoked was wrong, so It has > been changed in order to work as it was doing in the old method. > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/APRM_MatchingUtility.java > > Sandra Huguet <[email protected]> null > related to issue 29146 > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js > > Sandra Huguet <[email protected]> null > Fixed bug 29149 improve performance in UpdatePaymentPlan modulescript > > src-util/modulescript/build/classes/org/openbravo/modulescript/UpdatePaymentPlan.class > > src-util/modulescript/build/classes/org/openbravo/modulescript/UpdatePaymentPlanData.class > > src-util/modulescript/src/org/openbravo/modulescript/UpdatePaymentPlan.java > > src-util/modulescript/src/org/openbravo/modulescript/UpdatePaymentPlan_data.xsql > > Unai Martirena <[email protected]> null > Related to bug 29264: Delete obaprmAllRecordsSelectedByUser in > OrderInvoice Load > > While executing invalidateCache() function to reload OrderInvoice grid it > internally calls to 'OB.APRM.AddPayment.deselectAllRecords' overriden method > that sets obaprmAllRecordsSelectedByUser property to true. This property is > only needed when manually the select/unselect all checkbox is clicked. > > This was causing on certain scenarios that methods to update totals were not > being called: > * OB.APRM.AddPayment.updateInvOrderTotal(view.theForm, orderInvoice); > * OB.APRM.AddPayment.updateActualExpected(view.theForm); > * OB.APRM.AddPayment.updateDifference(view.theForm); > > So, in order to avoid this in OrderInvoiceOnLoad function, if the property > 'obaprmAllRecordsSelectedByUser' exists, it will be deleted. > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js > > Sandra Huguet <[email protected]> null > related to issue 29146 > > the validation only has to be considered when overpayment combo is visible > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js > > Alvaro Ferraz <[email protected]> null > Related to issue 29291: Update copyright > src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java > src/org/openbravo/erpCommon/businessUtility/PriceAdjustment.java > > Atul Gaware <[email protected]> null > Fixes Issue 29291:The sales order is not taking into account the unit > price of > the product when is 0 > > Corner case regression, when ever unit price is set to zero in the price list > src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java > src/org/openbravo/erpCommon/businessUtility/PriceAdjustment.java > > Asier Lostalé <[email protected]> null > fixed bug 29324: attachment download of different records at once fails > > It generated an invalid zip file. > > The problem was it tried to find the attachment directory based on the whole > list of ids to download instead of splitting it. > src/org/openbravo/erpCommon/businessUtility/TabAttachments.java > > Sandra Huguet <[email protected]> null > Fixed bug 29146: Used credit is not correct under certain circumstances > > modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js > > Augusto Mauch <[email protected]> null > Fixes bug 29293: valueMap & value of combo item are properly set in P&E > window > > There were two problems: > - The valueMap of the fk combo item was not being set because after the combo > refactor the FIC does not return the fk combo entries. To fix this, the > valueMap is built manually based on the selected option. > - The value of the combo item was being set before defining its valueMap. > When this happened no display value was shown in the combo. To fix this, the > value is reset just after defining the valueMap. > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js > > Augusto Mauch <[email protected]> null > Related with issue 29293: Checks if the okButton exists to prevent error > in log > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js > > Alvaro Ferraz <[email protected]> null > Related to issue 29301: Update copyright > src-db/database/model/functions/M_INOUT_POST.xml > > Eduardo Argal Guibert <[email protected]> null > Fixes issue 29301 > Cannot complete a goods receipt with a line without attribute set value if it > has a related prereservation. > Added coalesce when inserting to get default value > src-db/database/model/functions/M_INOUT_POST.xml > > Unai Martirena <[email protected]> null > Fixes bug 29264 Improved performance select/deselect all records in > OrderInv grid > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js > > Sandra Huguet <[email protected]> null > Fixed bug 29207 Payment Out is registered as "BP Deposit" transaction > > In FIN_TransactionProcess.java set the correct value depending on > the type of transaction > > modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/UpdateTransactionTypeTransactionTab.class > > modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/UpdateTransactionTypeTransactionTabData.class > > modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/UpdateTransactionTypeTransactionTab.java > > modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/UpdateTransactionTypeTransactionTab_data.xsql > > modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/UpdateTransactionTypeTransactionTabData.java > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java > > Augusto Mauch <[email protected]> null > Fixes issue 29253: 0 can be used to filter numeric columns > > In this changeset [1] this code was added to the > OBNumberItem.parseValueExpressions function: > > ret = this.Super('parseValueExpressions', [value, fieldName, operator]); > + > + // if operator is not supported remove it > + if (!this.validOperators.contains(ret.operator)) { > + ret.operator = ''; > + ret.value = ''; > + this.setValue(''); > + } > if (ret && ret.start) { > ret.start = this.convertToTypedValue(ret.start); > } > > The problem is that if the provided value is 0, > this.Super('parseValueExpressions', [value, fieldName, operator]) will return > undefined. This happens because of a bug in smartclient's implementation of > the > parseValueExpressions function. This code is placed at the beginning of that > function: > > if (!value) value = this.getValue(); > if (!value) return; > if (!isc.isA.String(value)) value += ""; > > If the provided value is 0, the value will be taken from this.getValue(). The > returned value will again be evaluated to false, so the function will not > return any value. Right after that, there is a comman > d to convert the provided value to String. > > To fix this, in the call to this.Super('parseValueExpressions'), the string > representation of the number will be passed instead of its numerical value. > This way smartclient will accept the value and will n > ot return undefined. Smartclient was already converting the passed values to > String, so there is no risk there. > > The value passed to the OBNumberItem.parseValueExpressions is not modified to > prevent unexpected consequences. A copy of it is converted to string and > passed to the this.Super('parseValueExpressions') func > tion. > > [1] > https://code.openbravo.com/erp/devel/pi/rev/d9ce373c75dad51598fb943d75e4d8e56f1d56eb > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js > > Alvaro Ferraz <[email protected]> null > Related to issue 29250: Added a clear inside the loop > > Added a clear inside the loop to avoid performance problems > src/org/openbravo/event/GLJournalEventHandler.java > > Atul Gaware <[email protected]> null > Fixes Issue 29250:It is not possible to change currency in header tab in > G/L Journal > > As there is trigger mutating error, updation of gl journal line currency and > currency rate is moved to a event handler from gl_journal_trg trigger. > src/org/openbravo/event/GLJournalEventHandler.java > src-db/database/model/triggers/GL_JOURNAL_TRG.xml > > Sandra Huguet <[email protected]> null > Related to issue 29148 > > If total selected amount is less than bank statement line amount, > the actual payment should be the bank statement line amount > and the difference should be consider overpayment. > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js > > Asier Lostalé <[email protected]> null > fixed bug 29217: can't prevent filtering FK by identifier from Grid > Configuration > > It was not possible to prevent filtering FKs by identifier using Grid > Configuration > because the js code added to ensure backwards compatibility for manual > datasources > was trying to find this property in an incorrect place which was undefined, > causing > a js exception which prevented the flow to continue. > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js > > Augusto Mauch <[email protected]> null > Fixes issue 29214: Filtering multiple products work in Return from/to P&E > > The problem was that the HQL WHERE clause built by the AdvancedQueryBuilder > was not proper, as it where using join aliases that where not present in the > FROM clause. This happened when the AdvancedQueryBuilder was used in the > HQLDataSourceService class, because that class uses the WHERE clause returned > by the AdvancedQueryBuilder, and the HQL FROM clause defined in the > application dictionary. The resulting HQL query was like this: > > SELECT iol.id as id, ... > FROM OrderLine AS ol LEFT JOIN ol.salesOrder AS o > WHERE ... > AND (( join_0.id = :alias_0 or join_0.id = :alias_1 ) ) > > The first two lines are built using the HQL transformers based on the HQL > defined in the application dictionary, and the last two lines are built using > the AdvancedQueryBuilder. The WHERE clause uses a join alias (join_0) that is > not defined in the FROM clause > > The new join alias was created in the resolveJoins method, that was invoked > when the criteria contained an OR operator. To fix this issue, a new flag, > creatingJoinsInWhereClauseIsPrevented, has been added. If this flag is true, > instead of creating a new join alias for the where clause, the clause will be > built using the entity main alias and the property name. As for now this new > flag is only set to true in the HqlDataSourceService class. > > modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java > > modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java > > Eduardo Argal Guibert <[email protected]> null > Related to issue 29199 > Problem with generated classes > > src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateBpPaymentLine.class > > src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateBpPaymentLineData.class > > Asier Lostalé <[email protected]> null > fixed issue 29155: added log on table recreation when updating database > src-db/database/lib/dbsourcemanager.jar > > Unai Martirena <[email protected]> null > Fixes bug 29194: Division by zero error managed in Costing Background. > > Under certain circumnstance a division by zero error was happening in Cost > Adjustments process inside Costing Background (when calculating backdated > adjustments of a transaction of movementqty zero). This problem has been > managed by being sure that this division will not happen again. If the > movementqty of the transaction is zero, the cost of the full transaction will > be zero as well. > src/org/openbravo/costing/AverageCostAdjustment.java > > Unai Martirena <[email protected]> null > Fixes Bug 29193: Cost properly calculated for orphan lines in Cost > Adjustments > > The process was failing for orphan lines because it was trying to get the > cost from a Purchase Price or an Standard Cost, and there is none. Before > checking those two, the process now tries to find an Average Cost for that > product on the movement date of the orphan line, and if it founds it assigns > to the transaction. > src/org/openbravo/costing/AverageCostAdjustment.java > src/org/openbravo/costing/CostingAlgorithmAdjustmentImp.java > > Sandra Huguet <[email protected]> null > Fixed bug 29148 It is not possible to create PaymentOut from "match > statement" > > It is not possible to create Payment Out from "match statement" using > a G/L item. > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js > > Eduardo Argal Guibert <[email protected]> null > Fixes issue 29199 > Fixes performance problem when missing index > > src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateBpPaymentLine.class > > src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateBpPaymentLineData.class > > src-util/modulescript/src/org/openbravo/modulescript/UpdateBpPaymentLine.java > > src-util/modulescript/src/org/openbravo/modulescript/UpdateBpPaymentLine_data.xsql > > Asier Lostalé <[email protected]> null > fixed bug 29143: PR14Q3 -> PR14Q4 update can fail activating FKs > > Added build validation to prevent this error. > > This build validation prevents issue #29127 by deleting rows in > ad_process_run for executions of > CostingRuleProcess which is removed but due to issue #29142 update database > process is not able > to properly handle. > > It is a temporary workaround and it should be removed one #29142 is > resolved. > > It should have been implemented as ModuleScript because it is repairing > data, but because > ad_process_run and ad_process_request tables are recreated when updating > from PR14Q3 to PR14Q4, > module script would be executed without indexes nor DB statistics which > might result, depending > on the data volumes in these table, in slow executions due to poor query > execution plans. > Exceptionally, implementing it as build validation to be executed before > actual database update > allowing better plans. > > src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/RemoveCostingRuleProcessExecutions.class > > src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/RemoveCostingRuleProcessExecutionsData.class > > src-util/buildvalidation/src/org/openbravo/buildvalidation/RemoveCostingRuleProcessExecutions.java > > src-util/buildvalidation/src/org/openbravo/buildvalidation/RemoveCostingRuleProcessExecutions_data.xsql > > Sandra Huguet <[email protected]> null > Fixed issue 29021 It is possible to process Payment Out without set amount > > Added a new validation in process button because it is not possible > to add a glitem with both amounts equal to 0. > Added a default value in received in and paid out fields in glitem > grid. > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js > > Unai Martirena <[email protected]> null > Fixes bug 29111: Valued Stock report filter properly by Product Category > > A new language parameter was added in the issue that has caused the > regression, but in wrong order, causing not to be able to filter by Product > Category. > Also a left join was being done instead of inner join, so the query was > displaying an wrong extra line with a sum up of all not necessary > m_transaction records. > src/org/openbravo/erpCommon/ad_reports/ReportValuationStock_data.xsql > > Alvaro Ferraz <[email protected]> null > Fixes issue 29029: SL_Journal_Period raises a NullPointer Exception > > AcctSchema will be retrieved only if acctSchemaId is not null (G/L Journal > Header tab). In other case (G/L Journal Batch tab) it will not. > src/org/openbravo/erpCommon/ad_callouts/SL_Journal_Period.java > > Alvaro Ferraz <[email protected]> null > Fixes issue 29041: Period is not automatically populated in G/L Journal > window > > Defaultvalue from C_Period_ID column in GL_JournalBatch table has been > changed to get current date instead of accounting date, which is null when > creating a new record. > src-db/database/sourcedata/AD_COLUMN.xml > > Alvaro Ferraz <[email protected]> null > Fixes issue 29016: G/L Journal Header dates are not copied from G/L > Journal > > Defaultvalues of document date and accounting date in G/L Journal Header tab > have been modified in order to be copied from G/L Journal Batch tab when the > window is G/L Journal. If the window is Simple G/L Journal, document date and > accounting date will be setted as current date. > src-db/database/sourcedata/AD_AUXILIARINPUT.xml > src-db/database/sourcedata/AD_COLUMN.xml > > Augusto Mauch <[email protected]> null > Fixes issue 29010: Grid is actually filtered using relative dates > > The problem was that when a relative date filter was added to the grid and > then used in a saved view, the saved view will not apply the relative date > filter, but an absolute one. This was caused by this code in the > OBViewGrid.convertCriteria function: > > if (this.dataSource) { > criteria = this.dataSource.convertRelativeDates(criteria); > } > > Every time that a criteria is sent to the backend (i.e. when storing a saved > view), the criteria objects that contained relative dates wwere converted to > absolute dates. This was done to fix this issue > [1], its problem being that the datasource used to populate the filter drop > down did not support relative dates. > > The function where that code was placed was too central, the criterias > converted should have been only the ones used to populate the filter drop > downs, but all the criterias were being converted. To fix this, the code has > been adapted and moved to the OBFKFilterTextItem.getPickListFilterCriteria > function. > [1] https://issues.openbravo.com/view.php?id=27679 > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js > > modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js > > Unai Martirena <[email protected]> null > Related to bug 29030: Code review. > > Fixed the copyright. > Add a clear on every 100 iterations of bankLinesSR Scrollable Results. > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadActionHandler.java > > Unai Martirena <[email protected]> null > Fixes bug 29030: Match Statement does not fail when a line throws an > exception > > In Matching Algorithm in Match Statement, if a line to be matched fails for > any reason (period closed for example) a rollback occurs. This rollback was > not being properly managed in Matching Algorithm after the refactor of Match > Statement window, so the process was failing instead of skipping that line > and going forward. Now it skips and the process finished successfully. > > modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadActionHandler.java > > Sandra Huguet <[email protected]> null > related to issue 28971 > > prevent javascript errors when thisview is null > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js > > Sandra Huguet <[email protected]> null > Fixed bug 28971 Cannot pay a negative invoice with a payment of 0 and a > GLItem > > Cannot pay a negative invoice with a payment of 0 and a GLItem because the > done > button is disabled. > > recalcDisplayLogicOrReadOnlyLogic() function should be executed in > updateGLItemsTotal > > modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js > > Changes for Build #1379 > > > > > Last 20 lines of the console output: > > [...truncated 28509 lines...] > method > org.openbravo.service.datasource.TreeDatasourceService.TooManyTreeNodesException.addSuppressed(java.lang.Throwable): > missing in /srv/ci/workspace/int-full-pgsql/SANDBOX/api-checks/output/java > method > org.openbravo.service.datasource.TreeDatasourceService.TooManyTreeNodesException.getSuppressed(): > missing in /srv/ci/workspace/int-full-pgsql/SANDBOX/api-checks/output/java > + failure=1 > + exit 1 > Build step 'Execute shell' marked build as failure > Performing Post build task... > Match found for : : True > Logical operation result is TRUE > Running script : cp > /srv/ci/workspace/int-full-pgsql/SANDBOX/api-checks/output/java.japi.gz . > [int-api] $ /bin/bash -xe /tmp/hudson5238172730062022352.sh > + cp /srv/ci/workspace/int-full-pgsql/SANDBOX/api-checks/output/java.japi.gz . > POST BUILD TASK : SUCCESS > END OF POST BUILD TASK : 0 > Archiving artifacts > Checking console output > /srv/ci/jobs/int-api/builds/2015-05-07_07-58-07/log: > [checkAPI] 14779 ERROR - > Email was triggered for: Failure > Sending email for trigger: Failure > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications > Performance metrics, stats and reports that give you Actionable Insights > Deep dive visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > _______________________________________________ > Openbravo-builds mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/openbravo-builds > ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Openbravo-builds mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openbravo-builds
