int-gui-oracle - Build # 1059 - Fixed:
Check console output at https://ci.openbravo.com/job/int-gui-oracle/1059/ to
view the results.
Committers since last success:
Changes for Build #1058
Inigo Sanchez <[email protected]> null
Fixed issue 29602: tab to check shouldn't be obtained from table's window
The problem was that tab to check shouldn't be obtained from table's window
but directly from the current window. Now it is taking into account.
modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java
David Miguelez [email protected]_ null
Fixes Issue 29992. Fixes HQL Where Clause in OBUISEL_Selector definition.
It now filters by Products that are Stocked based on the Product definition
rather than the Stocked flag in the Storage Detail.
src-db/database/sourcedata/AD_REFERENCE.xml
src-db/database/sourcedata/OBUISEL_SELECTOR.xml
src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
Stefan Hühner <[email protected]> null
Fixed 30056: Cleanup all warnings in src-wad
XX
- Remove String or int parameter assignment by copying into local variable.
- in Wad#processSelCol use Vector.toArray function to avoid needing to
replace reference in parameter. Note: .toArray will auto-resize itself
to correct size as param is 0-length array
- Fix 2 possible NPE. As code to treat null as empty value was only
called after .debug triggering NPE as param of log4j.debug will be evaluated
even without log level set to debug.
- Wad#getVectorElementsNotRepeated function had parameter which was new empty
Vector in all its 3 callers. As we do not expect more callers (was is
deprecated) just remove the param completely and create new Vector inside
the function removing param assignment.
- in WadUtility instead of assigning to text-param and immediately returning
that value just return it directly as the rest of that function already did.
- in WadNumber. Confusion between non-static function param name + field
inherited from superclass. As those seem to be very clearly utility
functions which should use the param (and not some inherited field) ->
just make them static to remove that confusion.
- WadValidator gets 'friendlyWarnings' flag on construction but does not
currently use it. However we may want to add it (and keep api stable now)
so just supress that unused warning.
src-wad/src/org/openbravo/wad/Wad.java
src-wad/src/org/openbravo/wad/WadUtility.java
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADImage.java
src-wad/src/org/openbravo/wad/controls/WADNumber.java
src-wad/src/org/openbravo/wad/controls/WADSearch.java
src-wad/src/org/openbravo/wad/validation/WADValidator.java
Stefan Hühner <[email protected]> null
Fixed 30055. Fix all warnings in src-trl
Two types of changes:
- Remove variables which are never read
- Do not assign to parameters, copy to local var instead
References of parameters cannot be modified in java
Content of objects passed in can be, however in all this
cases object are String which are immutable
Same fix always: Copy of local variable keeping name
of old param as new variable name to reduce diff to review.
- That avoid any developer confusing maybe thinking change
of param would be visible in caller.
src-trl/src/org/openbravo/translate/RTLSkin.java
src-trl/src/org/openbravo/translate/Translate.java
Stefan Hühner <[email protected]> null
Fixed 30054: Cleanup warnings in wad-generated code
Goal is not to make wad-generated code nicer (as it should go away).
But instead to reduce the big number of eclipse warnings in it.
So they get out of the way when looking at warning in other code
Changes:
- remove java.util.Arrays & java.util.List imports and covered by existing
java.util.* import
- The other 'unused' code warnings are not so easy to fix so in context of wad
supress all 'unused' warnings in the srcAD files on class level.
As secondary change remove to existing more specific unused annotation
as they triggered warnings themselves (and are covered by the new one anyway)
- Remove private log4j Logger declaration. It shadows a similar one coming
inherited from HttpBaseServer. That one is defined as non-static via
this.getClass so is already of the instance we want (the concrete window-
servlet). That means logger functionally works as before (you can still
set i.e. debug level logging for individual servlet as before).
- in printPageEdit function a parameter was being assigned to in the function
quite often. Apparently those cannot be surpressed. After checking easy to fix
- All caller use just simple constant on every call.
- So add local variable on top of function and copy param value.
- Keep existing param name as variable name to reduce diff of generated code.
Together those reduce number of warnings in srcAD from hundreds down to just 14.
src-wad/src/org/openbravo/wad/javasource.javaxml
Stefan Hühner <[email protected]> null
Issue 30053. Part 3: Delete local unused variables (easy cases)
This removes unused local variables / fields for all the easy cases.
Where there is no user besides the variables declaration/init and
where it is clear that just deleting it is the right thing to do (so
no doubt it should be used instead of deleting it)
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/PaymentProposalPickEditLines.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/PaymentSelectorFilterExpression.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ReconciliationProcess.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
src-core/src/org/openbravo/xmlEngine/XmlVectorValue.java
src-test/src/org/openbravo/test/dal/DalPerformanceExampleTest.java
src-wad/src/org/openbravo/wad/Wad.java
src/org/openbravo/base/model/ModelProvider.java
src/org/openbravo/common/actionhandler/RMInOutPickEditLines.java
src/org/openbravo/common/actionhandler/RMShipmentPickEditLines.java
src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
src/org/openbravo/erpCommon/ad_actionButton/EditCCPMeasureValues.java
src/org/openbravo/erpCommon/ad_callouts/SL_Asset_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_PC_Case_Product.java
src/org/openbravo/erpCommon/ad_process/DeleteClient.java
src/org/openbravo/erpCommon/ad_process/ResetAccountingProcess.java
src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.java
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR.java
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR_legacy.java
src/org/openbravo/erpCommon/ad_reports/ReportTrialBalance.java
src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
src/org/openbravo/event/InvoiceLineEventHandler.java
src/org/openbravo/event/MInOutLineEventHandler.java
Stefan Hühner <[email protected]> null
Issue 30053. Part 2: Cleanup unnecessary slf4j / log4j loggers
Remove those where they are private and never used in the file.
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadPreferenceActionHandler.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_FinaccTransactionEventListener.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/PaymentSelectorFilterExpression.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/TableTreeEventHandler.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/GetNameGeneralLedger.java
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/GetLabelActionHandler.java
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/SetContextInfoActionHandler.java
modules/org.openbravo.client.myob/src/org/openbravo/client/myob/CalendarWidgetProvider.java
src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransactionTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocLine_FINPayment.java
src/org/openbravo/erpCommon/utility/LeftTabsBar.java
src/org/openbravo/erpCommon/utility/NavigationBar.java
src/org/openbravo/erpCommon/utility/ToolBar.java
src/org/openbravo/erpCommon/utility/reporting/printing/PrintInvoices.java
src/org/openbravo/erpCommon/utility/reporting/printing/PrintOrders.java
src/org/openbravo/erpCommon/utility/reporting/printing/PrintQuotations.java
src/org/openbravo/erpCommon/utility/reporting/printing/PrintShipments.java
src/org/openbravo/service/system/ApplicationDictionaryValidator.java
Stefan Hühner <[email protected]> null
Issue 30053. Part 1: Cleanup unnecessary serialVersionUID variables.
Those definitions are not useful in this cases and the classes they are in
are not serializable.
So instead of special feature related to Serialization in this cases just a
local unused variable.
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServiceProvider.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ModelDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ReadOnlyDataSourceService.java
modules/org.openbravo.service.json/src/org/openbravo/service/json/QueryBuilder.java
src/org/openbravo/base/provider/OBProviderConfigReader.java
src/org/openbravo/erpCommon/ad_forms/DocAmortizationTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocBankTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocCashTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocDPManagementTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocDoubtfulDebt.java
src/org/openbravo/erpCommon/ad_forms/DocDoubtfulDebtTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocFINBankStatement.java
src/org/openbravo/erpCommon/ad_forms/DocFINBankStatementTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java
src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransactionTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
src/org/openbravo/erpCommon/ad_forms/DocFINPaymentTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocFINReconciliation.java
src/org/openbravo/erpCommon/ad_forms/DocFINReconciliationTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocGLJournalTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocInOutTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocInventoryTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocInvoiceTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocLCCostTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocLandedCostTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocMatchInvTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocMovementTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocOrderTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocPaymentTemplate.java
src/org/openbravo/erpCommon/ad_forms/DocProductionTemplate.java
src/org/openbravo/erpCommon/ad_forms/TranslationManager.java
src/org/openbravo/erpCommon/businessUtility/InitialClientSetup.java
src/org/openbravo/service/rest/DalWebService.java
Stefan Hühner <[email protected]> null
Fixed 30052. Cleanup all 'Unnecessary cast' warnings from Eclipse.
As those extra casts are not useful and make the code harder to read/understand
-> Remove all those
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/PaymentProposalPickEditLines.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddOrderOrInvoiceFilterExpressionHandler.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_BankStatementProcess.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ReconciliationProcess.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/GlobalMenu.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/MultipleDeleteActionHandler.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/OBBindings.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/RemoveImagesEventHandler.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/TreeTablesEventHandler.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/UpdateInvariantCharacteristicsHandler.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/UserInfoWidgetActionHandler.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationHandler.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ImagesActionHandler.java
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseComponent.java
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseComponentProvider.java
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelUtils.java
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinition.java
modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServiceProvider.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/LinkToParentTreeDatasourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java
modules/org.openbravo.service.json/src/org/openbravo/service/json/DataToJsonConverter.java
modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonToDataConverter.java
src-core/src/org/openbravo/base/VariablesBase.java
src-test/src/org/openbravo/test/dal/ADCachedMultiThreadTest.java
src-test/src/org/openbravo/test/xml/EntityXMLIssues.java
src/org/openbravo/base/model/Column.java
src/org/openbravo/base/model/ModelProvider.java
src/org/openbravo/base/session/OBYesNoType.java
src/org/openbravo/base/structure/IdentifierProvider.java
src/org/openbravo/common/actionhandler/KillProcess.java
src/org/openbravo/common/datasource/ResultMapCriteriaUtils.java
src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java
src/org/openbravo/costing/CostingAlgorithm.java
src/org/openbravo/costing/CostingMigrationProcess.java
src/org/openbravo/costing/CostingRuleProcess.java
src/org/openbravo/costing/CostingRuleProcessOnProcessHandler.java
src/org/openbravo/costing/InventoryAmountUpdateProcess.java
src/org/openbravo/costing/LCMatchingProcess.java
src/org/openbravo/costing/LandedCostDistributionByAmount.java
src/org/openbravo/costing/LandedCostProcess.java
src/org/openbravo/dal/security/SecurityChecker.java
src/org/openbravo/dal/service/OBDao.java
src/org/openbravo/dal/xml/EntityExcelXMLConverter.java
src/org/openbravo/dal/xml/EntityXMLConverter.java
src/org/openbravo/erpCommon/ad_actionButton/ExportReferenceData.java
src/org/openbravo/erpCommon/ad_callouts/SL_SequenceProduct_Product_Attribute.java
src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
src/org/openbravo/erpCommon/ad_forms/UpdateReferenceData.java
src/org/openbravo/erpCommon/ad_process/MRPPurchaseCreateReservations.java
src/org/openbravo/erpCommon/ad_process/RegisterModule.java
src/org/openbravo/erpCommon/businessUtility/InitialClientSetup.java
src/org/openbravo/erpCommon/info/ImageInfoBLOB.java
src/org/openbravo/erpCommon/modules/ImportModule.java
src/org/openbravo/erpCommon/modules/VersionUtility.java
src/org/openbravo/erpCommon/utility/GenericTree.java
src/org/openbravo/erpCommon/utility/Utility.java
src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
src/org/openbravo/erpReports/ReportVatRegisterJR.java
src/org/openbravo/materialmgmt/InventoryCountProcess.java
src/org/openbravo/materialmgmt/VariantAutomaticGenerationProcess.java
src/org/openbravo/materialmgmt/VariantChDescUpdateProcess.java
src/org/openbravo/service/db/CallProcess.java
src/org/openbravo/service/db/DataImportService.java
src/org/openbravo/service/importprocess/ImportProcessUtils.java
Changes for Build #1059
Inigo Sanchez <[email protected]> null
Related issue 29602:wrong position of parenthesis in a condition
The problem was the wrong position of parenthesis in a condicion. Now it has
been solved
by updating position of parenthesis properly,
modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java
Last 20 lines of the console output:
[...truncated 13069 lines...]
Total time: 2 seconds
executing script 'Tomcat stop'
[int-gui-oracle] $ /bin/bash /tmp/build_step_template7001948074624918449.sh
ENABLE
DEBUG: Tomcat stop called with parameters: ENABLED=ENABLE
* Stopping Tomcat servlet engine for Openbravo tomcat
...done.
executing script 'Check log'
[int-gui-oracle] $ /bin/bash /tmp/build_step_template5735375109830891663.sh
ENABLE
DEBUG: Check log called with parameters: ENABLED=
Check log: openbravo.log is clean
Recording test results
Archiving artifacts
Checking \] ERROR|\] WARN
Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed
------------------------------------------------------------------------------
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds
