int-upgrade-pgsql - Build # 1042 - Fixed:
Check console output at https://ci.openbravo.com/job/int-upgrade-pgsql/1042/ to
view the results.
Committers since last success:
Changes for Build #1041
Changes for Build #1042
Augusto Mauch <[email protected]> null
Related with issue 29612: Merge with pi
Augusto Mauch <[email protected]> null
Fixes issue 29612: FK filters with drop down disable behave like text
filters
If the "Disable Foreign Key Combo" grid configuration is enabled, then the
filters of foreign key fields will not include a dropdown. In this case the
filter will look like a standard text filter, so it ha
s been decided that is should act like one. This mean the following grid
properties should work:
- Text Field Filter Behaviour. Allows to specify the default operator, no
change was needed
- Threashold to Trigger Filter on Text Field. Prevents executing several
requests to the datasource in short time span. No change was needed
- Filter On Change: Allows to specify if a filter datasource request should be
done when the user types, before the filter editor loses the focus.
The changes done in this changeset fix the third case. The actOnKeypress
property is set to true if the FilterOnChange grid config is enabled, otherwise
the filter was only done when the filter editor lost
the focus. For this to work properly, another change was needed: the symbol of
the default operator should not be shown in the filter editor.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java
Augusto Mauch <[email protected]> null
Related with issue 29612: Adds display logic to Grid Configuration
Adds display logic to the Field tab of the Grid Configuration:
- If the Allow Filter field is set to No, the following fields are hidden: Text
Field Filter Behavior, Field On Change, Threshold to Trigger Filter on Text
Field, Disable Foreign Key Combo, Allow Filtering FOreign Keys by its
identifier and Unfiltered Foreign Key Combo
- If the Disable Foreign Key Combo field is set to Yes, the following fields
are hidden: Allow Filtering FOreign Keys by its identifier and Unfiltered
Foreign Key Combo
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
Augusto Mauch <[email protected]> null
Related with issue 29612: handle properly fk filter properties
>
> If the disableFkDropdown grid configuration is enabled, then the
> allowFkFilterByIdentifier and showFkDropdownUnfiltered should not be taken
> into account. Otherwise the user could configure the grid in a way that the
> fintering of a column is enabled, but non functional
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java
Augusto Mauch <[email protected]> null
Related with issue 29612: to_char needed in non-textual identifier
properties
When filtering a foreign key whose identifier is a column that does not use a
text/string reference, using the to_char function is still needed.
modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
src/org/openbravo/base/model/Property.java
Augusto Mauch <[email protected]> null
Related with issue 29612: Update Copyright year
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewUtil.java
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java
modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonConstants.java
Augusto Mauch <[email protected]> null
Related with issue 29612: Updates name to use Combo instead of Dropdown
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_ELEMENT.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
Augusto Mauch <[email protected]> null
Related with bug 29612: Applies properly the client/organizations filter
If the column being filtered referenced the Client or Organization entity, then
the resulting query was not including the where clause to filter the readable
clients and organizations, respectively. This is a known issue, reported here
[1].
This issue cannot be easily fixed, so this project address it by adding
manually the readable client or organization filter if the entity being
filtered is client or organization and if the query is being built as a result
of opening the dropdown of one of the new unfiltered foreign key filters.
[1] https://issues.openbravo.com/view.php?id=29846
modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
Augusto Mauch <[email protected]> null
Fixes issue 29612: Adds grid configuration to disable fk filter dropdown
Sometime the cost of populating a foreign key filter dropdown is much higher
than filtering its column using its identifier, like a standard text column.
This changeset adds a grid configuration to allow disabling the dropdown of
foreign key filters.
If the configuration is activated the use will not be able to open the
dropdown, not even using keyboard shortcuts. Saved views created before
enabling this configuration will keep working after activating it.
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_GC_FIELD.xml
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_GC_SYSTEM.xml
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_GC_TAB.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_ELEMENT.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewUtil.java
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java
Augusto Mauch <[email protected]> null
Fixes bug 29732: Get rid of coalesce(to_char()) when possible to improve
query
We sometimes use the coalesce(to_char(value),'') functions to prevent passing
null values in a where clause, replacing the null value with an empty string.
The problem is that if those functions are used, then it will not be possible
benefit from the indexes defined in the database.
In this issue we have made a distintion between mandatory and non-mandatory
columns. Mandatory columns will no longer use the coalesce and to_char
functions in the AdvancedQueryBuilder.createIdentifierLeftClause method. We can
do that safely as it is not possible that those columns have null values.
modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
Augusto Mauch <[email protected]> null
Related with bug 29612:New grid configuration to improve population of fk
combo
The new grid configuration allows to change the way the foreign key filter drop
downs are populated. Usually the rows shown in a fk filter drop down are only
those that are being used in the referencing table. But that can be very slow
if the referenced table has only a few records and the referenced tablas has a
huge volume.
To address this problem, this new grid configuration allows to show all the
records of the referenced table, even if they are not being used in the
referencing table. When the queryService is being created to populate the
filter drop down, the main entity is changed to the referenced table, and the
criteria is updated. Also the where clause of the referencing table is now
ignored.
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_GC_FIELD.xml
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_GC_SYSTEM.xml
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_GC_TAB.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_ELEMENT.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewUtil.java
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java
modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonConstants.java
Last 20 lines of the console output:
[...truncated 3667 lines...]
Total time: 1 second
executing script 'Tomcat stop'
[int-upgrade-pgsql] $ /bin/bash /tmp/build_step_template9183786136334979090.sh
ENABLE
DEBUG: Tomcat stop called with parameters: ENABLED=ENABLE
* Stopping Tomcat servlet engine for Openbravo tomcat
...done.
executing script 'Check log'
[int-upgrade-pgsql] $ /bin/bash /tmp/build_step_template594428451816418258.sh
ENABLE
DEBUG: Check log called with parameters: ENABLED=
Check log: openbravo.log is clean
Recording test results
Archiving artifacts
Checking \] ERROR|\] WARN
Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds
